Hv iox refactor #129
Open
Hv iox refactor #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mbedded into hvIOX_refactor
EUdds
requested changes
Jan 17, 2021
| @@ -0,0 +1,69 @@ | |||
| // Author: Marco | |||
There was a problem hiding this comment.
Perhaps add some comments to these tests so that someone who doesn't know what the functions are can tell what exactly is failing/passing
embedded/peripherals/src/hv_iox.cpp
Outdated
| if (this->setupIox() != 0) | ||
| isInit = false; | ||
| } | ||
| if (isInit) |
There was a problem hiding this comment.
An if/else statement here would be less confusing
| @@ -0,0 +1,10 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
this file generates a compile_commands.json file for the ccls language server. I use this for syntax checking and autocomplete. It also generates other crap I don't need which is the point of the git clean command. I also will run this command as a lazy way to fix build issues if there are untracked files messing up compilation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
converted the hv_iox.c file to cpp and update references accordingly
Type of change
refactoring to cpp
Problem
There are still warnings that were outside the scope of this feature