This repository has been archived by the owner on Oct 3, 2022. It is now read-only.
server: extend tag completion #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakape
suggested changes
Aug 16, 2020
db/tags.go
Outdated
| case "undefined": | ||
| prefix += s[:i+1] | ||
| s = s[i+1:] | ||
| typeQ = fmt.Sprintf(" and type = %d", common.Undefined) |
There was a problem hiding this comment.
Please move all cases of this into an embedded function to DRY this a bit.
Something like
completeWithPrefix := func (t common.TagType) {
prefix += s[:i+1]
s = s[i+1:]
typeQ = fmt.Sprintf(" and type = %d", t)
}
db/tags.go
Outdated
| if s[i+1:] != "" { | ||
| if s[i+1] == '-' { | ||
| prefix = "order:-" | ||
| re = regexp.MustCompile(`^` + regexp.QuoteMeta(s[i+2:]) + `.*`) |
There was a problem hiding this comment.
Return error instead of panicking.
db/tags.go
Outdated
| } | ||
| } else { | ||
| // Complete prefix | ||
| re := regexp.MustCompile(`^` + regexp.QuoteMeta(s) + `.*`) |
There was a problem hiding this comment.
Return error instead of panicking.
|
Ok, updated. So what about #54, should it be closed? |
|
While I'm here, fixed a bug. |
|
Okay, thank you! |
bakape
approved these changes
Aug 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17, closes #25
Left out #54 because we pretty much have the "all categories" functionality by just not specifying a category, and undefined is used for regular tags.