Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Laravel 10 #1406

Merged
merged 4 commits into from
Jan 22, 2023
Merged

Added support for Laravel 10 #1406

merged 4 commits into from
Jan 22, 2023

Conversation

stefvanesch
Copy link
Contributor

Summary

This pull request will add support for Laravel 10.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • Existing tests have been adapted and/or new tests have been added
  • Add a CHANGELOG.md entry
  • Update the README.md
  • Code style has been fixed via composer fix-style

@mfn
Copy link
Collaborator

mfn commented Jan 18, 2023

@stefvanesch thanks, seems we also need to exclude the invalid combinations from the matrix definitions; can you add this?

According do https://laravel.com/docs/master/releases#support-policy everything < 8.1 must be exluded.

@stefvanesch
Copy link
Contributor Author

@mfn I have very little experience with those test matrixes. If you could help with this that would be great.

@stefvanesch
Copy link
Contributor Author

@mfn would this be the way to go?

Screenshot 2023-01-18 at 17 19 31

@mfn
Copy link
Collaborator

mfn commented Jan 19, 2023

@stefvanesch yes, but I think you need to add this for all "php & laravel" combinations, which are not valid. This includes 7.4 and L10, 7.3 and L10, etc.

@barryvdh
Copy link
Owner

The integration tests cannot be run on 10.x yet

@barryvdh barryvdh merged commit 9e50460 into barryvdh:master Jan 22, 2023
d3v2a pushed a commit to d3v2a/laravel-ide-helper that referenced this pull request Feb 16, 2024
* Added support for Laravel 10

* Update run-tests.yml

* Update run-tests.yml

* Update run-integration-tests.yml

Co-authored-by: Barry vd. Heuvel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants