Add proxy-get over repl #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| false -> lager:info("REPL CS block skip disabled") | ||
| end, | ||
|
|
||
| ok = riak_api_pb_service:register(riak_repl_pb_get, 128), |
There was a problem hiding this comment.
This can be simplified into one line:
ok = riak_api_pb_service:register(riak_repl_pb_get, 128, 129),
Add tests for the rules too.
| @@ -0,0 +1,2 @@ | |||
| -define(REPLICATE_CS_USER_OBJECTS, true). | |||
There was a problem hiding this comment.
I'd be happy to put it in riak_repl.hrl if that's what you mean, just thought it'd be nice to have it separated out. Or did you mean having a default in a hrl at all?
There was a problem hiding this comment.
Yes, why does it need to be in a header at all, considering it is referenced in precisely one module.
There was a problem hiding this comment.
Yes good point, fixed in dcbe896
|
+1 to merge this into the 1.2 branch when above concerns are addressed. |
They were only used in one place, so no point in having them in a hrl.
|
Manually merged into 1.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also:
https://github.com/basho/riak-erlang-client/tree/adt-extra-messages <--- MERGED
https://github.com/basho/riak_moss/tree/dip_proxyget
Setup/testing docs:
https://github.com/basho/internal_wiki/wiki/Multidata-Center-Proxy-Gets