Fix issue #67 - New AssetStrategy #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
svycka
commented
Nov 16, 2017
| /** @var array */ | ||
| protected $file_extensions = []; | ||
|
|
||
| public function detect(LocaleEvent $event) |
There was a problem hiding this comment.
added because we don't want to run detect event on other strategies
svycka
commented
Nov 16, 2017
|
|
||
| // if the file extension of the uri is found within the configured file_extensions, we do not rewrite and skip further processing | ||
| if (in_array($extension, $this->file_extensions)) { | ||
| $event->stopPropagation(); |
There was a problem hiding this comment.
will strop event propagation instead of returning false and handling one more response type, also does not require any changes in Detector... better? :D
|
@basz if you don't see more problems I will merge this and release 0.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added tests and some modifications to #93
I have a bad feeling that
assemble()should be also stopped but not sure about this @basz ?