Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a11y: focus modals and esc closes err modal #310

Merged
merged 12 commits into from
Dec 18, 2019

Conversation

@microbit-mark microbit-mark changed the title a11y: esc closes err modal a11y: focus modals and esc closes err modal Nov 29, 2019
@microbit-mark microbit-mark marked this pull request as ready for review December 10, 2019 09:03
@microbit-carlos
Copy link
Collaborator

I've tested this on firefox and the WebUB not available modal was not focused. The esc key worked, but couldn't navigate to the "Find Out More" like with the keyboard.

@microbit-mark
Copy link
Contributor Author

microbit-mark commented Dec 11, 2019

I've tested this on firefox and the WebUB not available modal was not focused. The esc key worked, but couldn't navigate to the "Find Out More" like with the keyboard.

I can't recreate this issue. It seems to work for me

Screen Recording 2019-12-11 at 08 48 am

Does the text look grey in the title of the modal? Not sure why that happened, can't recreate again.

@microbit-carlos
Copy link
Collaborator

Why is the WebUSB text and cross grey? Do you have uncommited code in your local repo?

Pulling the latest code from this branch and still cannot tab into the modal (you can follow the mouse to see what tab is doing):

ezgif-3-ab457b962814

@microbit-mark
Copy link
Contributor Author

I have opened an issue for the link focus issue here https://github.com/microbit-foundation/platform-software-issue-tracker/issues/596

@microbit-carlos
Copy link
Collaborator

Hey @microbit-mark when testing the modalMsg (trigger for the webUSB-not-available message, or trying to load an .mpy file into the editor) I found a couple of issues with keeping the focus on the modal, so I've added a few commits.
Could you review them and run your tests?

There is also an issue with tabbing into the "Find Out More" link inside the WebUSB-not-available message, but that falls out of scope for this PR and we can fix as part of https://github.com/microbit-foundation/platform-software-issue-tracker/issues/596.

@microbit-mark
Copy link
Contributor Author

Thanks @microbit-carlos. LGTM I've tested the changes in FF, Safari Chrome and Edge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants