-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
a11y: focus modals and esc closes err modal #310
a11y: focus modals and esc closes err modal #310
Conversation
…itor into a11y-error-modals
I've tested this on firefox and the WebUB not available modal was not focused. The esc key worked, but couldn't navigate to the "Find Out More" like with the keyboard. |
I can't recreate this issue. It seems to work for me Does the text look grey in the title of the modal? Not sure why that happened, can't recreate again. |
I have opened an issue for the link focus issue here https://github.com/microbit-foundation/platform-software-issue-tracker/issues/596 |
1e29a7d
to
decb749
Compare
Hey @microbit-mark when testing the modalMsg (trigger for the webUSB-not-available message, or trying to load an .mpy file into the editor) I found a couple of issues with keeping the focus on the modal, so I've added a few commits. There is also an issue with tabbing into the "Find Out More" link inside the WebUSB-not-available message, but that falls out of scope for this PR and we can fix as part of https://github.com/microbit-foundation/platform-software-issue-tracker/issues/596. |
Thanks @microbit-carlos. LGTM I've tested the changes in FF, Safari Chrome and Edge |
closes https://github.com/microbit-foundation/platform-software-issue-tracker/issues/540 and closes https://github.com/microbit-foundation/platform-software-issue-tracker/issues/547