-
Notifications
You must be signed in to change notification settings - Fork 8
Create an uninstaller and updater, add support for ARM64/AARCH64 update readme and rename MAIN.sh to main.sh #6
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, sorry for that late reply,
Please look at the comments for each files and thanks a lot of your pull requests but it requires some changes to be better
systemctl daemon-reload | ||
# remove systemd service | ||
|
||
cp /etc/sudoers.beforewebra1n /etc/sudoers || fatal "Couldn't use /etc/sudoers backup" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fatal()
is a function I created in the original, as it's declared not in this file, calling it like this won't work.
Also crashing an uninstaller for such a reason doesnt seem a good idea to me
else | ||
fatal "Looks like we can't download checkra1n for you architecture ($arch)" | ||
fi | ||
|
||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to add a fi
@@ -16,10 +16,13 @@ arch=$(uname -m) | |||
|
|||
if [ "$(echo "$links" | grep "$arch")" ]; then | |||
link=$(echo "$links" | grep "$arch") | |||
else | |||
if arch=aarch64 ; then | |||
arch=arm64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works but I would prefer the whole script written in the same way, this might look better and more readable:
if [ "$arch" = "aarch64" ]; then
arch="arm64"
|
||
## To be done | ||
- [~~Checkra1n Downloader~~ ✅](/checkra1n-downloader/checkra1n-downloader.sh) | ||
- [~~Webra1n Service file~~ ✅](/webra1n.service) | ||
- Access point creator | ||
- [~~user creator for using `checkra1n` over SSH instead of HTTP~~ ✅](/MAIN.sh) | ||
- Raspberry Pi image | ||
- [~~Raspberry Pi image~~ ✅ ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it done ?
No description provided.