feat: add eip7702 support #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: add eip7702 support
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
filmakarov
requested changes
Dec 13, 2024
| ) external { | ||
| ) | ||
| external | ||
| payable |
There was a problem hiding this comment.
What is the use case for it to be payable?
There was a problem hiding this comment.
It's required when calling createAccount with msg.value using the new factory/proxy pattern (tests revert if it's not payable)
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR introduces new contracts and updates existing ones to enhance the Nexus framework for modular smart accounts, focusing on proxy deployment and initialization improvements, as well as validators and hooks management.
Detailed summary
MockTargetcontract for testing purposes.NexusProxyfor ERC1967 upgrade pattern.Initializablelibrary to manage initialization flags.K1ValidatorFactoryandNexusAccountFactoryto useProxyLibfor proxy deployment.