Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(oracle): NVL2 function #455

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nxtpge
Copy link

@nxtpge nxtpge commented Feb 19, 2025

This pull request allows to use the Oracle NVL2 function.

Also, the missing lint command described in the README.md was added in the composer.json.

It is based on the GitHub Actions workflows which led me to the ones defined in the Doctrine repository (PHP_CodeSniffer, PHPStan).

By the way, PHPStan found the following errors:

 ------ --------------------------------------------------------------------------------------------
  Line   tests/Query/DbTestCase.php
 ------ --------------------------------------------------------------------------------------------
  26     Call to an undefined static method Doctrine\ORM\ORMSetup::createDefaultAnnotationDriver().
         🪪  staticMethod.notFound
 ------ --------------------------------------------------------------------------------------------

 ------ --------------------------------------------------------------------------------------------
  Line   tests/Types/CarbonDateTest.php
 ------ --------------------------------------------------------------------------------------------
  54     Call to an undefined static method Doctrine\ORM\ORMSetup::createDefaultAnnotationDriver().
         🪪  staticMethod.notFound
  248    Call to an undefined method Doctrine\DBAL\Types\Type::requiresSQLCommentHint().
         🪪  method.notFound
 ------ --------------------------------------------------------------------------------------------

 ------ --------------------------------------------------------------------------------------------
  Line   tests/Types/ZendDateTest.php
 ------ --------------------------------------------------------------------------------------------
  41     Call to an undefined static method Doctrine\ORM\ORMSetup::createDefaultAnnotationDriver().
         🪪  staticMethod.notFound
  118    Call to an undefined method Doctrine\DBAL\Types\Type::requiresSQLCommentHint().
         🪪  method.notFound
 ------ --------------------------------------------------------------------------------------------

@nxtpge nxtpge force-pushed the feature/oracle-nvl2 branch from 2a1e07c to 992030b Compare February 19, 2025 22:05
@nxtpge
Copy link
Author

nxtpge commented Feb 19, 2025

Maybe it would be a good time to remove support for PHP 7.2 and 8.0 as they are not maintained anymore.

Is that worth considering or do I miss something due to my lack of experience in the open source @beberlei?

@nxtpge
Copy link
Author

nxtpge commented Feb 26, 2025

Hello @derrabus, do you know when are released new major and/or minor versions for this repository?

By looking at the dates of the previous ones, I did not find defined periods.

It will help me to understand when pull requests are merged.

Thank you for your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant