[Merged by Bors] - Fix mouse_clicked check for touches. #2029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems like a copy-paste from line 72 that was only partially modified. I don't know how to test this, so please verify me :)
|
Yup this looks correct to me, but we'll want someone with a touch screen to validate. I'd run this on my android phone, but currently android builds are broken :) |
Moxinilian
added
C-Bug
mockersf
added
the
S-Pre-Relicense
|
@alice-i-cecile done |
alice-i-cecile
removed
the
S-Pre-Relicense
alice-i-cecile
added
O-Android
|
bors r+ |
|
This is a trivial fix: we were triggering on button presses on touch releases, rather than touch presses. This is obviously incorrect. |
bors bot
pushed a commit
that referenced
this pull request
May 16, 2022
This seems like a copy-paste from line 72 that was only partially modified. I don't know how to test this, so please verify me :)
bors
bot
changed the title
robtfm
pushed a commit
to robtfm/bevy
that referenced
this pull request
May 17, 2022
This seems like a copy-paste from line 72 that was only partially modified. I don't know how to test this, so please verify me :)
exjam
pushed a commit
to exjam/bevy
that referenced
this pull request
May 22, 2022
This seems like a copy-paste from line 72 that was only partially modified. I don't know how to test this, so please verify me :)
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
This seems like a copy-paste from line 72 that was only partially modified. I don't know how to test this, so please verify me :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems like a copy-paste from line 72 that was only partially modified.
I don't know how to test this, so please verify me :)