Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve transformation tests #320

Open
tyarkoni opened this issue Dec 12, 2018 · 0 comments
Open

Improve transformation tests #320

tyarkoni opened this issue Dec 12, 2018 · 0 comments

Comments

@tyarkoni
Copy link
Collaborator

tyarkoni commented Dec 12, 2018

The transformation tests need some work. Specifically:

  • Instead of using the bundled ds005 dataset, which is large, we should start using fake datasets we can initialize more quickly and control more precisely. See test_dropna for an example.

  • Per discussion in Rename transform broken #318, the coverage of the transformation tests (in analysis/tests/test_transformations.py) is lacking: most of the tests only test using a dense variable or a sparse variable, and not both. It would be good to test both everywhere they're applicable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant