Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH/BF: add check for run_info to be a list, pass run_info in correct position. #353

Merged
merged 3 commits into from
Jan 25, 2019

Conversation

adswa
Copy link
Contributor

@adswa adswa commented Jan 24, 2019

Previously, a Split transformation failed, ref: #352.

This PR should hopefully fix this.

Also, @yarikoptic annihilated BIDSRunInfo which is not present anymore.

@tyarkoni
Copy link
Collaborator

Thanks! I guess the existing tests weren't catching this... Another reason to prioritize #320—this is like the 3rd time something's broken because it's only being tested using dense or sparse variables, but not both...

@tyarkoni
Copy link
Collaborator

LGTM once tests pass (well, minus that stoopid 3.5 failure).

@yarikoptic
Copy link
Collaborator

If you meant that it is the "Python: 2.7" on OSX with seems to be python 3.5 under:


UnsatisfiableError: The following specifications were found to be in conflict:
  - conda[version='>=4.5.12'] -> enum34 -> python[version='>=2.7,<2.8.0a0']
  - python=3.5
Use "conda info <package>" to see the dependencies for each package.
The command "if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then export MINICONDA=$HOME/miniconda; export PATH="$MINICONDA/bin:$PATH"; hash -r; echo $MINICONDA_URL; wget $MINICONDA_URL -O miniconda.sh; bash miniconda.sh -b -s -f -p $MINICONDA; conda config --set always_yes yes; conda info -a; conda install --quiet python=$PYTHON_VERSION; fi" failed and exited with 1 during .
Your build has been stopped.

then we are all set ;-)

@effigies effigies merged commit e9fc2df into bids-standard:master Jan 25, 2019
@effigies
Copy link
Collaborator

effigies commented Jan 27, 2019

@AdinaWagner Feel free to add yourself to the .zenodo.json.

My mistake. I see you're already in there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants