Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.13 and drop 3.9 #128

Merged
merged 4 commits into from
Feb 18, 2025
Merged

Conversation

cbrnr
Copy link
Collaborator

@cbrnr cbrnr commented Feb 18, 2025

That's it.

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.31%. Comparing base (8bf305b) to head (c478bf0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #128   +/-   ##
=======================================
  Coverage   99.31%   99.31%           
=======================================
  Files           2        2           
  Lines         293      293           
=======================================
  Hits          291      291           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sappelhoff
sappelhoff previously approved these changes Feb 18, 2025
Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! you could add a chnagelog entry for it, if you wanted to.

@cbrnr
Copy link
Collaborator Author

cbrnr commented Feb 18, 2025

I will, and let's wait until #127 is in.

@sappelhoff sappelhoff enabled auto-merge (squash) February 18, 2025 13:58
@sappelhoff
Copy link
Member

Thanks @cbrnr!

@cbrnr
Copy link
Collaborator Author

cbrnr commented Feb 18, 2025

Is it normal that these four jobs take forever to start?

@sappelhoff
Copy link
Member

sappelhoff commented Feb 18, 2025

Is it normal that these four jobs take forever to start?

nope, I just realized that when we change the CI runners (no 3.9 anymore, no 3.12 anymore, but 3.13) then we also need to change the config of which checks are expected.

Will do that now, that is something to do in the repo settings.

@sappelhoff sappelhoff disabled auto-merge February 18, 2025 15:27
@sappelhoff sappelhoff merged commit f59bcf3 into bids-standard:main Feb 18, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants