fix: return to window origin locally #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deov31
requested review from
icatalina,
LeoChowChina and
a team
as code owners
bc-micah
reviewed
Jan 28, 2025
| @@ -8,7 +8,7 @@ export const { | |||
| const { VITE_IS_LOCAL_ENVIRONMENT } = import.meta.env; | |||
|
|
|||
| const generateBcStorefrontAPIBaseUrl = () => { | |||
| if (VITE_IS_LOCAL_ENVIRONMENT === 'TRUE') return '/bigcommerce'; | |||
| if (VITE_IS_LOCAL_ENVIRONMENT === 'TRUE') return window.origin; | |||
There was a problem hiding this comment.
maybe this is not needed anymore.
There was a problem hiding this comment.
I followed your suggestion, you're right, it not needed
|
|
bc-victor
approved these changes
Jan 30, 2025
bc-micah
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
Thanks for fixing this.
Some suggestions for fixing the tests.
fix/B2B-2203...fix/B2B-2203-improve-tests
* fix: correct the tests * fix: clean console log --------- Co-authored-by: Micah Thomas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: B2B-2203
What/Why?
Using window origin url while login in local env. Right now is creating an incorrect url for the login graphql api call.
/bigcommerce/graphqlRollout/Rollback
Revert
Testing
login to buyer portal locally