Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(shipping): SHIPPING-3338 Publish documentation for v3 channel based out of zone delivery message #834

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bc-msung
Copy link
Contributor

@bc-msung bc-msung commented Feb 24, 2025

SHIPPING-3329

What changed?

  • Providing documentation for v3/shipping/settings/{channel_id} endpoint.
  • Updating property name for out_of_zone_delivery_message in v3/shipping/settings endpoint to out_of_delivery_zone_message
  • Added missing http error responses

References:

Out of delivery zone message property update
Channel based settings endpoint
Published route in api-proxy

Anything else?

SHIPPING-3449 Update name of out of delivery zone message property
SHIPPING-3336 Create an v1/internalapi endpoint for channel based out of delivery message
SHIPPING-3337 Expose the endpoint which handles channel based out of delivery message

Screenshot

Channel based settings endpoint
Screenshot 2025-02-24 at 11 55 36 am

Settings endpoint (property name update)
Screenshot 2025-02-24 at 11 56 34 am

ping @bigcommerce/team-shipping @bigcommerce/dev-docs

@bc-msung bc-msung marked this pull request as ready for review February 24, 2025 02:26
benpratt77
benpratt77 previously approved these changes Feb 24, 2025
@bc-msung bc-msung force-pushed the SHIPPING-3338 branch 2 times, most recently from c6c8bd6 to 8a633a3 Compare February 25, 2025 00:04
theromulans
theromulans previously approved these changes Feb 25, 2025
Copy link
Contributor

@theromulans theromulans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like just a minor item remaining, lets goooo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants