-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(shipping): SHIPPING-3338 Publish documentation for v3 channel based out of zone delivery message #834
Open
bc-msung
wants to merge
1
commit into
main
Choose a base branch
from
SHIPPING-3338
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+158
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benpratt77
reviewed
Feb 24, 2025
4e0de04
to
2de1506
Compare
benpratt77
reviewed
Feb 24, 2025
2de1506
to
227ffcd
Compare
benpratt77
previously approved these changes
Feb 24, 2025
theromulans
reviewed
Feb 24, 2025
theromulans
reviewed
Feb 24, 2025
c6c8bd6
to
8a633a3
Compare
theromulans
reviewed
Feb 25, 2025
theromulans
reviewed
Feb 25, 2025
theromulans
previously approved these changes
Feb 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like just a minor item remaining, lets goooo.
8a633a3
to
576d7b9
Compare
…ased out of zone delivery message
576d7b9
to
a55991f
Compare
theromulans
approved these changes
Feb 25, 2025
benpratt77
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SHIPPING-3329
What changed?
v3/shipping/settings/{channel_id}
endpoint.out_of_zone_delivery_message
inv3/shipping/settings
endpoint toout_of_delivery_zone_message
References:
Out of delivery zone message property update
Channel based settings endpoint
Published route in api-proxy
Anything else?
SHIPPING-3449 Update name of out of delivery zone message property
SHIPPING-3336 Create an v1/internalapi endpoint for channel based out of delivery message
SHIPPING-3337 Expose the endpoint which handles channel based out of delivery message
Screenshot
Channel based settings endpoint

Settings endpoint (property name update)

ping @bigcommerce/team-shipping @bigcommerce/dev-docs