-
-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Copyright violation? #911
Comments
The MIT license says:
I does not go into details as to where exactly the attribution should be made, only that its present, so I think that what we're currently doing is fine. Mind you I'm no lawyer either. |
I read a bit online about how things work. Here are some things that I found that should answer our questions:
And of course, I am no expert. I will keep this open in case someone with more expertise than us can shed some light. Unfortunately, Rome Tools Inc. is no more, so I am not sure how things would work. |
The new licenses are applied only to new written code. This should not cause legal issues. It is a common thing among projects. |
This file is missing from Biome's public npm package and perhaps other distributions of the software. I guess this is easy to fix.
This is not my understanding. The public npm package's package.json says "MIT OR Apache-2.0":
I think this means that I (a recipient of Biome) can use Biome's Apache 2 license and ignore the MIT license. Doing this effectively replaces the Rome MIT license with Biome's Apache 2. I think this is not allowed by the MIT license.
Agreed; I didn't think so. I'm talking about the current version of Biome.
I understand what you are saying. As I showed above, though, Biome is seemingly removing the Rome MIT license from old code. |
I am not sure because Apache 2.0 is a stricter version of MIT. If the consumer wants to consume Apache 2.0, they must copy the license AND provide a statement that says "This part of the code was heavily changed". Still, this is in line with MIT. |
(Just chiming in as someone that's also been interested in relicensing under MIT OR Apache-2.0 in the past...) When dual licensing under MIT OR Apache-2.0, you are requiring that all inbound contributions are licensed under both licenses, and allowing consumers of the code to choose either license to govern their use. My understanding (IANAL) is that you need explicit permission from the copyright holders (i.e., the contributors) in order to relicense from MIT to an MIT OR Apache-2.0 dual license. Otherwise, you're effectively relicensing MIT-licensed code (i.e., contributions made prior to the relicense) over which you do not hold copyright. Back in 2016, there was a campaign around relicensing crates as per this policy -- you can see it in action in sfackler/rust-postgres-macros#19, rust-lang/rustup#44, etc. What you could do is license future inbound contributions under the dual-license. But consumers of the library would still need to be "consuming" it as an MIT licensed project, since the project includes code that isn't licensed under Apache-2.0. I'm not sure how exactly you'd operationalize this (like, what you'd put in your LICENSE file and the license fields), but in theory it would mean that when you went around to relicense the project in the future, you wouldn't need to ask for explicit permission from committers that contributed after that date. |
Apache 2.0 is not a superset of MIT. If you have software licensed under Apache 2.0 (but not also MIT), you do not need to follow these instructions from the MIT license:
@charliermarsh's interpretation of the Apache 2.0 and MIT licenses, and software licensing in general, matches my understanding. |
(1) was recently completed. We now include the Rome copyright inside the MIT license files. Regarding (2), to address any concerns, I suggest relicensing the old Rome code as well. |
Environment information
What happened?
I was looking at Biome's software license and noticed two potential problems:
ROME_LICENSE
files with attribution, but they seem easy to miss compared to the mainLICENSE-MIT
file.I think these might be problems; I am not certain. (I am not a lawyer at all.)
Expected result
I expect one of the following:
Code of Conduct
The text was updated successfully, but these errors were encountered: