refactor: more renamings to Biome #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conaclos
temporarily deployed
to
Website deployment
GitHub Actions
Inactive
github-actions
bot
added
A-CLI
Conaclos
force-pushed
the
conaclos/more-renamings
branch
from
ded97d7 to
1ac2420
Compare
Conaclos
temporarily deployed
to
Website deployment
GitHub Actions
Inactive
ematipico
reviewed
Aug 19, 2023
| @@ -1,6 +1,10 @@ | |||
| MIT License | |||
|
|
|||
| Copyright (c) Rome Tools, Inc. and its affiliates. | |||
| Biome is a fork of Rome Tools (https://github.com/rome/tools). | |||
There was a problem hiding this comment.
I'm not a lawyer, but I think we should play it safe:
- she should keep the original license. We can name the file to
ROME_LICENSE - generate a new MIT
LICENSEfile, using the template provided (GitHub, or other websites)
That's how we have always done when we copied code from other sources.
There was a problem hiding this comment.
I think both ways are ok. Anyway, I can make the change.
There was a problem hiding this comment.
From Wikipedia
the MIT License also permits reuse within proprietary software, provided that all copies of the software or its substantial portions include a copy of the terms of the MIT License and also a copyright notice.
Let's make a copy, I believe the safest choice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the LICENSE files with proper credits to Rome Tools and other projects.
This also add some contexts in the CHANGELOG file and apply more renaming.
Test Plan
CI.