Added 500+ string translations to Russian language file #7268
Conversation
Previously, about 1,585 out of 2,676 strings (59.23%) were translated into Russian, the rest remained in English. This meant a native Russian speaker with limited English ability might have great difficulty using Bisq application and might not understand or notice the way the system works and the many important pop-ups that can appear. Now there are about 2,103 strings in Russian (78.59%) and most of the messages the end user normally would see are displayed in Russian, making the application very usable.
Minor typographical correction: Added back a blank line to preserve line number matching during code review. No change to strings.
|
|
||
| portfolio.pending.step2_buyer.refTextWarn=Important: when making the payment, leave the \"reason for payment\" field empty. DO NOT put the trade ID or any other text like 'bitcoin', 'BTC', or 'Bisq'. If you are required to fill in a reason, use your account name eg "Joe Bloggs", alternatively enter something non-descriptive like a dash (-). You are free to discuss via trader chat if an alternate \"reason for payment\" would be suitable to you both. | ||
| portfolio.pending.step2_buyer.refTextWarn=Важно: при совершении платежа оставьте поле \«причина платежа\» пустым. НЕ вводите идентификатор сделки или любой другой текст, например ''биткоин'', ''bitcoin'', ''BTC'' или ''Bisq''. Если вам необходимо указать причину, используйте имя своей учетной записи, например, \«Джон Блоггс\», или введите что-то неописательное, например, тире (-). Вы можете свободно обсудить в чате трейдеров, подойдет ли вам обоим альтернативная \«причина платежа\». |
There was a problem hiding this comment.
As here is not variable used (e.g. {0}) the duplicate single quote is not needed and would get displayed as duplicate quote. Only if a variable and a single quote occurs in a string we need to duplicate it.
There was a problem hiding this comment.
Good catch, I fixed that one plus all the other incorrect doubling up's (or missing doubling up's) in the default (English) and other language files. However, French and Italian have a large number of incorrect apostrophes because of stress marks used in the language itself (see comment below for an example), so fixing those will need to be a separate pull request, as it's far outside the scope of this pull request to add Russian translations.
Code Review follow-up - fix incorrect instances of "''"
vs. "'" when substitutions ("{0}", etc.) are present or
absent.
| @@ -3477,7 +3477,7 @@ validation.sortCodeChars={0} doit être composer de {1} caractères. | |||
| validation.bankIdNumber={0} doit être composer de {1} chiffres. | |||
| validation.accountNr=Le numéro du compte doit comporter {0} chiffres. | |||
| validation.accountNrChars=Le numéro du compte doit comporter {0} caractères. | |||
| validation.btc.invalidAddress=L''adresse n''est pas correcte. Veuillez vérifier le format de l''adresse. | |||
| validation.btc.invalidAddress=L'adresse n'est pas correcte. Veuillez vérifier le format de l'adresse. | |||
There was a problem hiding this comment.
This is an example of the problems remaining in just French and Italian, as using an apostrophe for accent/stress is pervasive in these languages, and doubling-up for the Java properties file requirement is sometimes done incorrectly.
There was a problem hiding this comment.
I added a commit to fix a situation that I found where substitution parameters are missing (or were removed at some time) but the code was still trying to to do the replacements. That is another way these inconsistencies can happen (though certainly not the only way), and really the correct way to fix such these cases is to modify the code to not pass the (unused) replacements as I have done in this case (no guarantees that there aren't others). Really though, an even better solution for everyone (which should have been done at day-1) would be enhance Res.get() to perform the apostrophe double-up itself when replacement parameters are provided and make the language files consistent.
Code Review follow-up - Remove substition replacements for strings which do not have any substition parameters, as these are causing confusion as to whether apostrophes are required.
Previously, about 1,585 out of 2,676 strings (59.23%) were translated into Russian, the rest remained in English. This meant a native Russian speaker with limited English ability might have great difficulty using Bisq application and might not understand or notice the way the system works and the many important pop-ups that can appear. Now there are about 2,103 strings in Russian (78.59%) and most of the messages the end user normally would see are displayed in Russian, making the application very usable.
Testing was done in Russian language mode using both connection to the actual Bisq P2P network with live data, as well as using Alice, Bob, & Mediator to walk through the trade process (with and without mediation and arbitration), in order to find which strings are important but missing a translation, as well as to verify that strings fit as well as possible in the space provided. In some cases, existing translations were changed (ex: "Fiat" was previously translated into "Natl. Currency", but fiat is also a borrowed word in Russian and was changed to transliteration, and also "Offer ID" had been translated "Identificator Offer", but that way too long for the space available so "ID Offer" in Russian is good enough).
Preceded by PR #7253