added bionic builder host, others minor fixes #41
Conversation
cisba
commented
Sep 23, 2018
cisba
commented
- added document describing how to create an Ubuntu VirtualBox builder host
- added document describing how to setup Gitian on the builder host
- removed the initial make-base-vm of the Gitian image from the tail
of Gitian setup document for Debian and Fedora, because it is already
inside the gitian-build.py script
- minor improvements and fixes to the signing procedure
| ```bash | ||
| cd gitian-builder | ||
| git checkout 686a00ad712e30ba3a7850c16ef32f650df5b5dc # This version seems to work better than master | ||
| bin/make-base-vm --lxc --arch amd64 --suite trusty |
There was a problem hiding this comment.
Why is this removed? The build script can only create a bionic image and when running without the build script, this step is required.
There was a problem hiding this comment.
If you do this step here, the build script fails because the image is already present.
If you run without the build script, you find the step in gitian-building-manual.md.
There was a problem hiding this comment.
BTW, my aim was this: bitcoin/bitcoin#12511 (comment)
There was a problem hiding this comment.
At this moment I'm building 0.16.3 and I noted that:
tag 0.17.x has the script gitian-build.py with bionic;
tag 0.15.x and 0.16.x have the script gitian-build.sh with trusty.
The base vm suite choice, from 0.15.0 is delegated to the script version released in each tag.
Before 0.15.0 there is no script: the manual setup of the base vm is required.
To setup gitian from 0.15.0 to 0.16.x it is necessary to checkout the specific gitian-build.sh of the tag, or to setup gitian running the make-base-vm manually.
So removing the step "make-base-vm" works fine only for gitian setup of 0.17.x.
A different approach could be to enable gitian-build.py to extract "suite"
contrib/gitian-descriptors/gitian-*.yml
then "make-base-vm" with that "suite" value.
BTW, if the base vm is already present, should the script use it or delete it and make a new one?
There was a problem hiding this comment.
I understand just now...
Leaving the manual step to make-base-vm trusty is a trick to have the gitian setup for older tags.
Instead the gitian-build.py is in charge of executing make-base-vm bionic for 0.17.x and later.
:)
I will fix it asap.
- restored the last section “Setting up the Gitian image” in files gitian-building-setup-gitian-*.md with explanation that is necessary to build bitcoin 0.16.x and earlier
- added a line to disable the lxcbr0 bridge (enabled by default in recent package) in conflict with the br0 in rc.local
|
@MarcoFalke I found the lxc bridge issue not very easy to solve, probably it is blocking for newcomers. Do you think it is better to put it in a dedicated PR to merge quickly? |
|
What is the version that enables this bridge? |
|
|
Here the lxc-net service script that uses those defaults: |
|
./contrib/gitian-build.py line 49: Similar workaround already present for the same issue. |
|
I want to add some PRs on my own that edit this file. I also wanted to fix up some issues with the LXC building, however, it works on Ubuntu (since unlike Debian it doesn't have ancient versions) Do you plan to merge this and switch from Debian to Ubuntu? |
|
Sorry, needs rebase |
Done |
|
Closing, now that we have migrated away from using gitian. |
