Install headers automatically #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix install all the headers under include/ into /usr/local/include. The fix solves problems that arise when building libraries that depend on secp256k1 such as bitcoin-system which require all the headers
|
ACK. This seems right to me, and I don't see any harm in installing headers for disabled modules. |
gmaxwell
added a commit
that referenced
this pull request
May 23, 2019
16e8615 Install headers automatically (Víctor Mayoral Vilches) Pull request description: This fix install all the headers under include/ into /usr/local/include. The fix solves problems that arise when building libraries that depend on secp256k1 such as libbitcoin-system which require all the headers Tree-SHA512: 8a5dc664b278e47340bf7478ad278306c44c4c8ad17a023b198c6a927c67c7a7a50100357388342129078afdf7606d2ed06579ce1fc14195fa974510b933021b
|
It's no real harm but won't users be confused when there are headers installed that actually won't work? I think it's better to install the headers depending on whether the modules are enables. I can create a PR if you agree. |
doitian
added a commit
to doitian/secp256k1
that referenced
this pull request
May 24, 2019
This reverts commit 91fae3a, reversing changes made to 5df77a0. See discussion in bitcoin-core#625 After the change, if we enable any module, `make install` fails because of the duplicated files in the command line arguments.
gmaxwell
added a commit
that referenced
this pull request
May 24, 2019
662918c Revert "Merge #620: Install headers automatically" (ian) Pull request description: This reverts commit 91fae3a, reversing changes made to 5df77a0. See discussion in #625 After the change, if we enable any module, `make install` fails because of the duplicated files in the command line arguments. Closes #624 Tree-SHA512: 7769ede527ac307bff094603e5974c56b19e41bc2ef55113173d3dbc8e545d6add7ae044753fa0361595e5e7a746d6c8d641f98caa3381b683aa2b61a1742097
|
Apparently we already were. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix install all the headers under include/ into
/usr/local/include. The fix solves problems that arise
when building libraries that depend on secp256k1 such
as libbitcoin-system which require all the headers