gitian-build.sh cleanup #13628
Closed
gitian-build.sh cleanup #13628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongcarl
force-pushed
the
gitian-build-cleanup
branch
from
175232c to
ed8cb7d
Compare
dongcarl
force-pushed
the
gitian-build-cleanup
branch
from
2e837b7 to
2a6150d
Compare
|
How about starting with just the shellcheck commit, and maybe pairing it with a shellcheck test/linter? Just a suggestion. |
|
I'm afraid this PR is redundant due to #13623, which ports the script to Python. Please help reviewing and testing that one instead. |
Note to reviewers: This pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build()bash function