Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guix: use GCC 13 to build releases #29881

Merged
merged 2 commits into from
Feb 19, 2025
Merged

Conversation

fanquake
Copy link
Member

@fanquake fanquake commented Apr 15, 2024

Switch release builds to using GCC 13.3.0: https://gcc.gnu.org/gcc-13/, which landed in Guix in: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=750148ce1ea6c65a7c14424546db0078161f7e17.

Does not solve the cross-arch non-determinism for powerpc64le-linux-gnu builds.

@DrahtBot
Copy link
Contributor

DrahtBot commented Apr 15, 2024

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/29881.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK hebasto, TheCharlatan, achow101
Concept ACK theuni

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #30595 (kernel: Introduce initial C header API by TheCharlatan)
  • #25573 ([POC] guix: produce a fully -static-pie bitcoind by fanquake)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@maflcko
Copy link
Member

maflcko commented Apr 16, 2024

For reference, the previous bump was e1ce5b8, which is in master only and not yet in a release branch.

@maflcko
Copy link
Member

maflcko commented Apr 17, 2024

CI should be bumped as well, if this is taken out of draft. Just leaving a comment here, so that it isn't forgotten.

@fanquake fanquake force-pushed the gcc_13_v2 branch 2 times, most recently from 005e3e6 to 51cf84c Compare May 23, 2024 09:08
@fanquake
Copy link
Member Author

CI should be bumped as well, if this is taken out of draft.

Added a (WIP) commit to bump a couple CIs to 13.2.0. Also bumped the time-machine further, now that we've upstreamed GCC 13.3.0: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=750148ce1ea6c65a7c14424546db0078161f7e17.

@fanquake
Copy link
Member Author

Looks like Windows still has false positives with GCC 13.2.0 (https://github.com/bitcoin/bitcoin/pull/29881/checks?check_run_id=25320716500):

torcontrol.cpp: In static member function ‘static void TorControlConnection::readcb(bufferevent*, void*)’:
torcontrol.cpp:94:28: error: ‘result’ may be used uninitialized [-Werror=maybe-uninitialized]
   94 |         self->message.code = ToIntegral<int>(s.substr(0, 3)).value_or(0);
      |         ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ./netaddress.h:14,
                 from ./torcontrol.h:11,
                 from torcontrol.cpp:6:
./util/strencodings.h:184:7: note: ‘result’ was declared here
  184 |     T result;
      |       ^~~~~~
cc1plus: all warnings being treated as errors
make[2]: *** [Makefile:11115: libbitcoin_node_a-torcontrol.o] Error 1

Will re-add -Wno-error=maybe-uninitialized.

@DrahtBot
Copy link
Contributor

🚧 At least one of the CI tasks failed. Make sure to run all tests locally, according to the
documentation.

Possibly this is due to a silent merge conflict (the changes in this pull request being
incompatible with the current code in the target branch). If so, make sure to rebase on the latest
commit of the target branch.

Leave a comment here, if you need help tracking down a confusing failure.

Debug: https://github.com/bitcoin/bitcoin/runs/25320716500

@DrahtBot
Copy link
Contributor

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File commit 413844f
(master)
commit f70535d
(master and this pull)
SHA256SUMS.part 7038b1f0a46354d0... bb71668da81259bc...
*-aarch64-linux-gnu-debug.tar.gz a76cf9d2e152936e... cc23ba69ad9db416...
*-aarch64-linux-gnu.tar.gz ab985105e7cedd7f... adcb35d2cd950d61...
*-arm-linux-gnueabihf-debug.tar.gz f04965bbddd723f9... 791edaa8462a419f...
*-arm-linux-gnueabihf.tar.gz 1b9426003d080c21... 1af02c6c8163ee8a...
*-arm64-apple-darwin-unsigned.tar.gz 53fd58f6a90d3eef... 7d5d20cf05f33ee3...
*-arm64-apple-darwin-unsigned.zip de1e633dccff0884... c622b31a0dff11ae...
*-arm64-apple-darwin.tar.gz 38df91fa08312b5c... 5e82e59de294a79a...
*-powerpc64-linux-gnu-debug.tar.gz 97d1fff618262135... d7645af9e49996cd...
*-powerpc64-linux-gnu.tar.gz d42801c8e6d40fc6... aa6aebd82603773d...
*-riscv64-linux-gnu-debug.tar.gz 7e0e9aa798b6ca6a... 8236df12f99e30c5...
*-riscv64-linux-gnu.tar.gz 45d9eb35efa7923f... 3768c6b6f584f97f...
*-x86_64-apple-darwin-unsigned.tar.gz ebd24cb269e39ed2... dd7233949c9a0fe5...
*-x86_64-apple-darwin-unsigned.zip 47b3b02eb59892a2... 264a883cbafa8515...
*-x86_64-apple-darwin.tar.gz c8599974bcbbded3... 63af668d266a165d...
*-x86_64-linux-gnu-debug.tar.gz 545c7991048b1b47... c251dea8add73796...
*-x86_64-linux-gnu.tar.gz c928fbbed3980669... e2a8be1b2cd5c2dd...
*.tar.gz cfeb27b61490c0c5... 1a48734408d12b20...
guix_build.log 9eff9e4ba83245a2... d199625b849c6c8b...
guix_build.log.diff eb0d91385d995bdc...

@fanquake fanquake force-pushed the gcc_13_v2 branch 2 times, most recently from 348e6c8 to 569ff3f Compare May 29, 2024 08:58
fanquake added a commit to fanquake/bitcoin that referenced this pull request Jun 5, 2024
Includes:
LLVM 18.1.x (bitcoin#30201)
GCC 13.x (bitcoin#29881)
Kernel Headers 6.1.80 -> 6.1.92
Commits like
https://git.savannah.gnu.org/cgit/guix.git/commit/?id=7b0f145802f0c2c785014293d748721678fef824,
which should improve the bootstrap situation (bitcoin#30042).
fanquake added a commit to fanquake/bitcoin that referenced this pull request Jun 5, 2024
Includes:
LLVM 18.1.x (bitcoin#30201)
GCC 13.x (bitcoin#29881)
Kernel Headers 6.1.80 -> 6.1.92
Commits like
https://git.savannah.gnu.org/cgit/guix.git/commit/?id=7b0f145802f0c2c785014293d748721678fef824,
which should improve the bootstrap situation (bitcoin#30042).
fanquake added a commit to fanquake/bitcoin that referenced this pull request Jun 5, 2024
Includes:
LLVM 18.1.x (bitcoin#30201)
GCC 13.x (bitcoin#29881)

git-minimal 2.41.0 -> 2.45.1
Kernel Headers 6.1.80 -> 6.1.92
moreutils 0.68 -> 0.69

Commits like
https://git.savannah.gnu.org/cgit/guix.git/commit/?id=7b0f145802f0c2c785014293d748721678fef824,
which should improve the bootstrap situation (bitcoin#30042).
@TheCharlatan
Copy link
Contributor

Guix builds (aarch64):

463ef2208f9c5ce3cf884fd2cf8fba8f2aabded19ba43620178aea41e8c8fd1d  guix-build-a1add80c80bc/output/aarch64-linux-gnu/SHA256SUMS.part
3a87fe313164fed822437e35511febdbdf0d8e9feda099dfef4fd9031735916f  guix-build-a1add80c80bc/output/aarch64-linux-gnu/bitcoin-a1add80c80bc-aarch64-linux-gnu-debug.tar.gz
a20f31417cbb9994eed0e88700c3e1f8c714282425cbe5fb33a5c7ac7b7c68c2  guix-build-a1add80c80bc/output/aarch64-linux-gnu/bitcoin-a1add80c80bc-aarch64-linux-gnu.tar.gz
51fbc8b8ad7cfbdf4ac694c1892a773dcacd0985d1d3d2a8eb0f7d3e8d6c08e4  guix-build-a1add80c80bc/output/arm-linux-gnueabihf/SHA256SUMS.part
fe7578a017db172d045f380ce813df1b153af2ef7a19949f99aa670da7eb3abb  guix-build-a1add80c80bc/output/arm-linux-gnueabihf/bitcoin-a1add80c80bc-arm-linux-gnueabihf-debug.tar.gz
bbaaab6ad5d6353dfa7d7922cdb59fb405c325dbac7f6a403d426eca1c1d2883  guix-build-a1add80c80bc/output/arm-linux-gnueabihf/bitcoin-a1add80c80bc-arm-linux-gnueabihf.tar.gz
4bc11eb1b400eba8b80b0e36dad598fe3f840c44302c49303c8135c4e747f859  guix-build-a1add80c80bc/output/arm64-apple-darwin/SHA256SUMS.part
14f5b8ba07e0efc5fec68583de3511b1d3014bbe13d91736234130151557ad98  guix-build-a1add80c80bc/output/arm64-apple-darwin/bitcoin-a1add80c80bc-arm64-apple-darwin-unsigned.tar.gz
16e9e5d93449e6944eb2df033f7211364cff985da899f8a191b45ba51a30d3fc  guix-build-a1add80c80bc/output/arm64-apple-darwin/bitcoin-a1add80c80bc-arm64-apple-darwin-unsigned.zip
e715a1db58ea26c116e5a071dcfaa57d12b209af14c15007a218fd7527eb33bf  guix-build-a1add80c80bc/output/arm64-apple-darwin/bitcoin-a1add80c80bc-arm64-apple-darwin.tar.gz
d3761b12727cefa187bab5453d38fa4b41424bd32118087aaca5bcb84d8e1447  guix-build-a1add80c80bc/output/dist-archive/bitcoin-a1add80c80bc.tar.gz
44d96cfc04400cbc159918dca8dfaa36490024d764682eb395add0fc9b90e7af  guix-build-a1add80c80bc/output/powerpc64-linux-gnu/SHA256SUMS.part
c30be7c6acbc808bb4c54aa44017883c934727f79733f14c5b3b5a8080e494d5  guix-build-a1add80c80bc/output/powerpc64-linux-gnu/bitcoin-a1add80c80bc-powerpc64-linux-gnu-debug.tar.gz
9211491c5a33404d39320a8383d328d7424449b393373d4770eb7d9d2d9a4fb8  guix-build-a1add80c80bc/output/powerpc64-linux-gnu/bitcoin-a1add80c80bc-powerpc64-linux-gnu.tar.gz
c0a9e681aabe0c3bae43063a05240344f1e789cb14988e3b492f7c313d07f046  guix-build-a1add80c80bc/output/riscv64-linux-gnu/SHA256SUMS.part
247d3c1be8f133b55baac10027ee57b309453935ff5620d28d544a6d8315639e  guix-build-a1add80c80bc/output/riscv64-linux-gnu/bitcoin-a1add80c80bc-riscv64-linux-gnu-debug.tar.gz
99cb063a2304e434d8203b84e6ad8a186093aa072edfc3d6b7e7e5bfd5e286bc  guix-build-a1add80c80bc/output/riscv64-linux-gnu/bitcoin-a1add80c80bc-riscv64-linux-gnu.tar.gz
12c5d097c387bb496962485bd387f4b51d3dddc61f3ac97d87662762f0ef9cc0  guix-build-a1add80c80bc/output/x86_64-apple-darwin/SHA256SUMS.part
bad6029968165bbe2500f2badfe836b36e24715ed38cd106509a0a9f598b9583  guix-build-a1add80c80bc/output/x86_64-apple-darwin/bitcoin-a1add80c80bc-x86_64-apple-darwin-unsigned.tar.gz
524b35ce2caf7491fade68b6f77cf05e0e9add1b65cc0440e93712f1138c31a2  guix-build-a1add80c80bc/output/x86_64-apple-darwin/bitcoin-a1add80c80bc-x86_64-apple-darwin-unsigned.zip
761571cfcbd0dbaa04baa9c7e20699671fbac5b7e0dacc853ceb6dd4a48394aa  guix-build-a1add80c80bc/output/x86_64-apple-darwin/bitcoin-a1add80c80bc-x86_64-apple-darwin.tar.gz
fe8988a5c3775445a29661dd231ba0ad535147c00ab82e3f95fc237acd37d894  guix-build-a1add80c80bc/output/x86_64-linux-gnu/SHA256SUMS.part
7b44ec9ba029a00c5906259238e0571f0a028344bcb115df16572416e930b755  guix-build-a1add80c80bc/output/x86_64-linux-gnu/bitcoin-a1add80c80bc-x86_64-linux-gnu-debug.tar.gz
819d13cbd5a28bdbf42166207a7d65b85836f68e42ca87ea1cf24c77a2579c79  guix-build-a1add80c80bc/output/x86_64-linux-gnu/bitcoin-a1add80c80bc-x86_64-linux-gnu.tar.gz
7764c34e1bd5dc23e421ce912aab1495a8a604a8fb012366d2d3eadbcbb88df6  guix-build-a1add80c80bc/output/x86_64-w64-mingw32/SHA256SUMS.part
17e2358409facf970bd249cde55a8c9b1d9321c209a6b6cea215208b301ac92b  guix-build-a1add80c80bc/output/x86_64-w64-mingw32/bitcoin-a1add80c80bc-win64-debug.zip
b74aa4fe72e0aaa4f0e5e3085f22cb371ba0eaec64ed3223b6885a2df37c12bc  guix-build-a1add80c80bc/output/x86_64-w64-mingw32/bitcoin-a1add80c80bc-win64-setup-unsigned.exe
1cef0f2097c1db85f69c95e890d0e9ed682a8a4f237354ca8879eb9c3a133d30  guix-build-a1add80c80bc/output/x86_64-w64-mingw32/bitcoin-a1add80c80bc-win64-unsigned.tar.gz
e038a66938f33520b682b981b97d46d75a5c473a4ce4b25464b20d13db5bf384  guix-build-a1add80c80bc/output/x86_64-w64-mingw32/bitcoin-a1add80c80bc-win64.zip

@fanquake
Copy link
Member Author

Guix Build (x86_64):

a22efc082966018f6ddd17d1a7092ffda56900895dd4694080244257e1c5c974  guix-build-6f0513613a98/output/aarch64-linux-gnu/SHA256SUMS.part
ad65ac733f93931c5fcfa09afc2a1f8bed76cd5280be9b569ff9bdf15dec3abe  guix-build-6f0513613a98/output/aarch64-linux-gnu/bitcoin-6f0513613a98-aarch64-linux-gnu-debug.tar.gz
abc9037335e719927525c0474a7959db57a6f3f64d9522474ede4d88e721f73c  guix-build-6f0513613a98/output/aarch64-linux-gnu/bitcoin-6f0513613a98-aarch64-linux-gnu.tar.gz
fdb01866f033273d588340e533840ecfd3d9ed51d91676b3324de3c7a26d114e  guix-build-6f0513613a98/output/arm-linux-gnueabihf/SHA256SUMS.part
5873b129b2cf9efc36770a25c7f2315c491368cf30a61ee3677ec6283d64507d  guix-build-6f0513613a98/output/arm-linux-gnueabihf/bitcoin-6f0513613a98-arm-linux-gnueabihf-debug.tar.gz
eca5831c1cc9e8894fc1b2576530f49e55f02e28e4a5b18712fbe5390c5c2894  guix-build-6f0513613a98/output/arm-linux-gnueabihf/bitcoin-6f0513613a98-arm-linux-gnueabihf.tar.gz
82d1d8a1dd594fe1ac74a9bef6b95b29b9072c9b97170eb415d079d2b23df0dd  guix-build-6f0513613a98/output/arm64-apple-darwin/SHA256SUMS.part
87701bec7a281857660cec63f53c5eec2bc1aca613fbc915dbff0832f6fcc048  guix-build-6f0513613a98/output/arm64-apple-darwin/bitcoin-6f0513613a98-arm64-apple-darwin-unsigned.tar.gz
0061861b901390bcd35998f50a4aebc72cbe0e0d0ba0d6e5a723c25e0df60bd2  guix-build-6f0513613a98/output/arm64-apple-darwin/bitcoin-6f0513613a98-arm64-apple-darwin-unsigned.zip
ee4fb897f7b1edce434b49e33f2d57e8c19609616a2de81b69af7dbe4d3345d1  guix-build-6f0513613a98/output/arm64-apple-darwin/bitcoin-6f0513613a98-arm64-apple-darwin.tar.gz
dd84d6066534402a58247e810214f88488c7d8b63a5c10a70dff63e7b283318c  guix-build-6f0513613a98/output/dist-archive/bitcoin-6f0513613a98.tar.gz
1b3e385809dcb62aa07d8ccbe6320f9f3c3da97c2ab3d53cc5f0b29930fa57bf  guix-build-6f0513613a98/output/powerpc64-linux-gnu/SHA256SUMS.part
384e0727561e6e26dad72c5921b69b7f3ec2318668d7aa6e73a5075cb31c1225  guix-build-6f0513613a98/output/powerpc64-linux-gnu/bitcoin-6f0513613a98-powerpc64-linux-gnu-debug.tar.gz
4b2d077c2901c704bfff704def1ed4dd11b221bfc8fc2a3577e9f63b3dd32e27  guix-build-6f0513613a98/output/powerpc64-linux-gnu/bitcoin-6f0513613a98-powerpc64-linux-gnu.tar.gz
83b1d34c4189530cea18aaa89f55628c9df23bbf9abe6ecf3fd9f62abcff1df4  guix-build-6f0513613a98/output/riscv64-linux-gnu/SHA256SUMS.part
54bfb1ef49ae9567d3f79a8c959ce1580b4cd4add47a7611992d37fa9c3dd84c  guix-build-6f0513613a98/output/riscv64-linux-gnu/bitcoin-6f0513613a98-riscv64-linux-gnu-debug.tar.gz
19cea2c3cda1374bb6c969df706d344c91737a061cc23e997bec1368c1af2420  guix-build-6f0513613a98/output/riscv64-linux-gnu/bitcoin-6f0513613a98-riscv64-linux-gnu.tar.gz
a4defa1c1c3948c134705cd3c25a96a4e98a6c5b884c5eebb1948f1b7af7e865  guix-build-6f0513613a98/output/x86_64-apple-darwin/SHA256SUMS.part
0b745d24fa17ecaeb85404c3e6335f96e0cd975668d6c0f6ce2f4fd75c68b5aa  guix-build-6f0513613a98/output/x86_64-apple-darwin/bitcoin-6f0513613a98-x86_64-apple-darwin-unsigned.tar.gz
049f56eccc19ac292ebc2df00ee18cc063cde109306ab2dba716c3f2bf5bfaf0  guix-build-6f0513613a98/output/x86_64-apple-darwin/bitcoin-6f0513613a98-x86_64-apple-darwin-unsigned.zip
20784bac737e7b9da1fb9743ad76dd4e0d4659743e4ae857f40ab4c551843571  guix-build-6f0513613a98/output/x86_64-apple-darwin/bitcoin-6f0513613a98-x86_64-apple-darwin.tar.gz
3f799bfc0ca76314873508b95f3a577c2b48eed4bf3509d14b9945809c241c4b  guix-build-6f0513613a98/output/x86_64-linux-gnu/SHA256SUMS.part
843dcd76b6c0b3eb5f252603969a973ef6668b02473f06ebe55a19642e203d6f  guix-build-6f0513613a98/output/x86_64-linux-gnu/bitcoin-6f0513613a98-x86_64-linux-gnu-debug.tar.gz
2f2aa78458c679b7233b2201f4e4604e08a705b1eed9731f67a9128f15088c5c  guix-build-6f0513613a98/output/x86_64-linux-gnu/bitcoin-6f0513613a98-x86_64-linux-gnu.tar.gz
d658030334948903847a56f3ab2058219aaf04f65126af92075551ea7c3055d0  guix-build-6f0513613a98/output/x86_64-w64-mingw32/SHA256SUMS.part
4270d8383256376b8d751203baa6c57f83bda3d1868cfa0aa9ea87fd0684b95c  guix-build-6f0513613a98/output/x86_64-w64-mingw32/bitcoin-6f0513613a98-win64-debug.zip
403150548e9fe249b035ef2641a8d1faad22d881561092b0c232d4779439a130  guix-build-6f0513613a98/output/x86_64-w64-mingw32/bitcoin-6f0513613a98-win64-setup-unsigned.exe
7195be67f54f369923deb56bc07682f64b3cd68eeb986085e0e2cb9542bf6d1f  guix-build-6f0513613a98/output/x86_64-w64-mingw32/bitcoin-6f0513613a98-win64-unsigned.tar.gz
86809fdb4d014e57b3137b1db9889ed68c73cce1e04f1ec837f0a121fd9315c6  guix-build-6f0513613a98/output/x86_64-w64-mingw32/bitcoin-6f0513613a98-win64.zip

@hebasto
Copy link
Member

hebasto commented Jan 20, 2025

My Guix build:

riscv64
a22efc082966018f6ddd17d1a7092ffda56900895dd4694080244257e1c5c974  guix-build-6f0513613a98/output/aarch64-linux-gnu/SHA256SUMS.part
ad65ac733f93931c5fcfa09afc2a1f8bed76cd5280be9b569ff9bdf15dec3abe  guix-build-6f0513613a98/output/aarch64-linux-gnu/bitcoin-6f0513613a98-aarch64-linux-gnu-debug.tar.gz
abc9037335e719927525c0474a7959db57a6f3f64d9522474ede4d88e721f73c  guix-build-6f0513613a98/output/aarch64-linux-gnu/bitcoin-6f0513613a98-aarch64-linux-gnu.tar.gz
fdb01866f033273d588340e533840ecfd3d9ed51d91676b3324de3c7a26d114e  guix-build-6f0513613a98/output/arm-linux-gnueabihf/SHA256SUMS.part
5873b129b2cf9efc36770a25c7f2315c491368cf30a61ee3677ec6283d64507d  guix-build-6f0513613a98/output/arm-linux-gnueabihf/bitcoin-6f0513613a98-arm-linux-gnueabihf-debug.tar.gz
eca5831c1cc9e8894fc1b2576530f49e55f02e28e4a5b18712fbe5390c5c2894  guix-build-6f0513613a98/output/arm-linux-gnueabihf/bitcoin-6f0513613a98-arm-linux-gnueabihf.tar.gz
82d1d8a1dd594fe1ac74a9bef6b95b29b9072c9b97170eb415d079d2b23df0dd  guix-build-6f0513613a98/output/arm64-apple-darwin/SHA256SUMS.part
87701bec7a281857660cec63f53c5eec2bc1aca613fbc915dbff0832f6fcc048  guix-build-6f0513613a98/output/arm64-apple-darwin/bitcoin-6f0513613a98-arm64-apple-darwin-unsigned.tar.gz
0061861b901390bcd35998f50a4aebc72cbe0e0d0ba0d6e5a723c25e0df60bd2  guix-build-6f0513613a98/output/arm64-apple-darwin/bitcoin-6f0513613a98-arm64-apple-darwin-unsigned.zip
ee4fb897f7b1edce434b49e33f2d57e8c19609616a2de81b69af7dbe4d3345d1  guix-build-6f0513613a98/output/arm64-apple-darwin/bitcoin-6f0513613a98-arm64-apple-darwin.tar.gz
dd84d6066534402a58247e810214f88488c7d8b63a5c10a70dff63e7b283318c  guix-build-6f0513613a98/output/dist-archive/bitcoin-6f0513613a98.tar.gz
1b3e385809dcb62aa07d8ccbe6320f9f3c3da97c2ab3d53cc5f0b29930fa57bf  guix-build-6f0513613a98/output/powerpc64-linux-gnu/SHA256SUMS.part
384e0727561e6e26dad72c5921b69b7f3ec2318668d7aa6e73a5075cb31c1225  guix-build-6f0513613a98/output/powerpc64-linux-gnu/bitcoin-6f0513613a98-powerpc64-linux-gnu-debug.tar.gz
4b2d077c2901c704bfff704def1ed4dd11b221bfc8fc2a3577e9f63b3dd32e27  guix-build-6f0513613a98/output/powerpc64-linux-gnu/bitcoin-6f0513613a98-powerpc64-linux-gnu.tar.gz
83b1d34c4189530cea18aaa89f55628c9df23bbf9abe6ecf3fd9f62abcff1df4  guix-build-6f0513613a98/output/riscv64-linux-gnu/SHA256SUMS.part
54bfb1ef49ae9567d3f79a8c959ce1580b4cd4add47a7611992d37fa9c3dd84c  guix-build-6f0513613a98/output/riscv64-linux-gnu/bitcoin-6f0513613a98-riscv64-linux-gnu-debug.tar.gz
19cea2c3cda1374bb6c969df706d344c91737a061cc23e997bec1368c1af2420  guix-build-6f0513613a98/output/riscv64-linux-gnu/bitcoin-6f0513613a98-riscv64-linux-gnu.tar.gz
a4defa1c1c3948c134705cd3c25a96a4e98a6c5b884c5eebb1948f1b7af7e865  guix-build-6f0513613a98/output/x86_64-apple-darwin/SHA256SUMS.part
0b745d24fa17ecaeb85404c3e6335f96e0cd975668d6c0f6ce2f4fd75c68b5aa  guix-build-6f0513613a98/output/x86_64-apple-darwin/bitcoin-6f0513613a98-x86_64-apple-darwin-unsigned.tar.gz
049f56eccc19ac292ebc2df00ee18cc063cde109306ab2dba716c3f2bf5bfaf0  guix-build-6f0513613a98/output/x86_64-apple-darwin/bitcoin-6f0513613a98-x86_64-apple-darwin-unsigned.zip
20784bac737e7b9da1fb9743ad76dd4e0d4659743e4ae857f40ab4c551843571  guix-build-6f0513613a98/output/x86_64-apple-darwin/bitcoin-6f0513613a98-x86_64-apple-darwin.tar.gz
3f799bfc0ca76314873508b95f3a577c2b48eed4bf3509d14b9945809c241c4b  guix-build-6f0513613a98/output/x86_64-linux-gnu/SHA256SUMS.part
843dcd76b6c0b3eb5f252603969a973ef6668b02473f06ebe55a19642e203d6f  guix-build-6f0513613a98/output/x86_64-linux-gnu/bitcoin-6f0513613a98-x86_64-linux-gnu-debug.tar.gz
2f2aa78458c679b7233b2201f4e4604e08a705b1eed9731f67a9128f15088c5c  guix-build-6f0513613a98/output/x86_64-linux-gnu/bitcoin-6f0513613a98-x86_64-linux-gnu.tar.gz
d658030334948903847a56f3ab2058219aaf04f65126af92075551ea7c3055d0  guix-build-6f0513613a98/output/x86_64-w64-mingw32/SHA256SUMS.part
4270d8383256376b8d751203baa6c57f83bda3d1868cfa0aa9ea87fd0684b95c  guix-build-6f0513613a98/output/x86_64-w64-mingw32/bitcoin-6f0513613a98-win64-debug.zip
403150548e9fe249b035ef2641a8d1faad22d881561092b0c232d4779439a130  guix-build-6f0513613a98/output/x86_64-w64-mingw32/bitcoin-6f0513613a98-win64-setup-unsigned.exe
7195be67f54f369923deb56bc07682f64b3cd68eeb986085e0e2cb9542bf6d1f  guix-build-6f0513613a98/output/x86_64-w64-mingw32/bitcoin-6f0513613a98-win64-unsigned.tar.gz
86809fdb4d014e57b3137b1db9889ed68c73cce1e04f1ec837f0a121fd9315c6  guix-build-6f0513613a98/output/x86_64-w64-mingw32/bitcoin-6f0513613a98-win64.zip

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-ACK 6f05136, only rebased since my recent review.

Copy link
Contributor

@TheCharlatan TheCharlatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 6f05136

Guix build (aarch64):

a22efc082966018f6ddd17d1a7092ffda56900895dd4694080244257e1c5c974  guix-build-6f0513613a98/output/aarch64-linux-gnu/SHA256SUMS.part
ad65ac733f93931c5fcfa09afc2a1f8bed76cd5280be9b569ff9bdf15dec3abe  guix-build-6f0513613a98/output/aarch64-linux-gnu/bitcoin-6f0513613a98-aarch64-linux-gnu-debug.tar.gz
abc9037335e719927525c0474a7959db57a6f3f64d9522474ede4d88e721f73c  guix-build-6f0513613a98/output/aarch64-linux-gnu/bitcoin-6f0513613a98-aarch64-linux-gnu.tar.gz
fdb01866f033273d588340e533840ecfd3d9ed51d91676b3324de3c7a26d114e  guix-build-6f0513613a98/output/arm-linux-gnueabihf/SHA256SUMS.part
5873b129b2cf9efc36770a25c7f2315c491368cf30a61ee3677ec6283d64507d  guix-build-6f0513613a98/output/arm-linux-gnueabihf/bitcoin-6f0513613a98-arm-linux-gnueabihf-debug.tar.gz
eca5831c1cc9e8894fc1b2576530f49e55f02e28e4a5b18712fbe5390c5c2894  guix-build-6f0513613a98/output/arm-linux-gnueabihf/bitcoin-6f0513613a98-arm-linux-gnueabihf.tar.gz
82d1d8a1dd594fe1ac74a9bef6b95b29b9072c9b97170eb415d079d2b23df0dd  guix-build-6f0513613a98/output/arm64-apple-darwin/SHA256SUMS.part
87701bec7a281857660cec63f53c5eec2bc1aca613fbc915dbff0832f6fcc048  guix-build-6f0513613a98/output/arm64-apple-darwin/bitcoin-6f0513613a98-arm64-apple-darwin-unsigned.tar.gz
0061861b901390bcd35998f50a4aebc72cbe0e0d0ba0d6e5a723c25e0df60bd2  guix-build-6f0513613a98/output/arm64-apple-darwin/bitcoin-6f0513613a98-arm64-apple-darwin-unsigned.zip
ee4fb897f7b1edce434b49e33f2d57e8c19609616a2de81b69af7dbe4d3345d1  guix-build-6f0513613a98/output/arm64-apple-darwin/bitcoin-6f0513613a98-arm64-apple-darwin.tar.gz
dd84d6066534402a58247e810214f88488c7d8b63a5c10a70dff63e7b283318c  guix-build-6f0513613a98/output/dist-archive/bitcoin-6f0513613a98.tar.gz
1b3e385809dcb62aa07d8ccbe6320f9f3c3da97c2ab3d53cc5f0b29930fa57bf  guix-build-6f0513613a98/output/powerpc64-linux-gnu/SHA256SUMS.part
384e0727561e6e26dad72c5921b69b7f3ec2318668d7aa6e73a5075cb31c1225  guix-build-6f0513613a98/output/powerpc64-linux-gnu/bitcoin-6f0513613a98-powerpc64-linux-gnu-debug.tar.gz
4b2d077c2901c704bfff704def1ed4dd11b221bfc8fc2a3577e9f63b3dd32e27  guix-build-6f0513613a98/output/powerpc64-linux-gnu/bitcoin-6f0513613a98-powerpc64-linux-gnu.tar.gz
83b1d34c4189530cea18aaa89f55628c9df23bbf9abe6ecf3fd9f62abcff1df4  guix-build-6f0513613a98/output/riscv64-linux-gnu/SHA256SUMS.part
54bfb1ef49ae9567d3f79a8c959ce1580b4cd4add47a7611992d37fa9c3dd84c  guix-build-6f0513613a98/output/riscv64-linux-gnu/bitcoin-6f0513613a98-riscv64-linux-gnu-debug.tar.gz
19cea2c3cda1374bb6c969df706d344c91737a061cc23e997bec1368c1af2420  guix-build-6f0513613a98/output/riscv64-linux-gnu/bitcoin-6f0513613a98-riscv64-linux-gnu.tar.gz
a4defa1c1c3948c134705cd3c25a96a4e98a6c5b884c5eebb1948f1b7af7e865  guix-build-6f0513613a98/output/x86_64-apple-darwin/SHA256SUMS.part
0b745d24fa17ecaeb85404c3e6335f96e0cd975668d6c0f6ce2f4fd75c68b5aa  guix-build-6f0513613a98/output/x86_64-apple-darwin/bitcoin-6f0513613a98-x86_64-apple-darwin-unsigned.tar.gz
049f56eccc19ac292ebc2df00ee18cc063cde109306ab2dba716c3f2bf5bfaf0  guix-build-6f0513613a98/output/x86_64-apple-darwin/bitcoin-6f0513613a98-x86_64-apple-darwin-unsigned.zip
20784bac737e7b9da1fb9743ad76dd4e0d4659743e4ae857f40ab4c551843571  guix-build-6f0513613a98/output/x86_64-apple-darwin/bitcoin-6f0513613a98-x86_64-apple-darwin.tar.gz
3f799bfc0ca76314873508b95f3a577c2b48eed4bf3509d14b9945809c241c4b  guix-build-6f0513613a98/output/x86_64-linux-gnu/SHA256SUMS.part
843dcd76b6c0b3eb5f252603969a973ef6668b02473f06ebe55a19642e203d6f  guix-build-6f0513613a98/output/x86_64-linux-gnu/bitcoin-6f0513613a98-x86_64-linux-gnu-debug.tar.gz
2f2aa78458c679b7233b2201f4e4604e08a705b1eed9731f67a9128f15088c5c  guix-build-6f0513613a98/output/x86_64-linux-gnu/bitcoin-6f0513613a98-x86_64-linux-gnu.tar.gz
d658030334948903847a56f3ab2058219aaf04f65126af92075551ea7c3055d0  guix-build-6f0513613a98/output/x86_64-w64-mingw32/SHA256SUMS.part
4270d8383256376b8d751203baa6c57f83bda3d1868cfa0aa9ea87fd0684b95c  guix-build-6f0513613a98/output/x86_64-w64-mingw32/bitcoin-6f0513613a98-win64-debug.zip
403150548e9fe249b035ef2641a8d1faad22d881561092b0c232d4779439a130  guix-build-6f0513613a98/output/x86_64-w64-mingw32/bitcoin-6f0513613a98-win64-setup-unsigned.exe
7195be67f54f369923deb56bc07682f64b3cd68eeb986085e0e2cb9542bf6d1f  guix-build-6f0513613a98/output/x86_64-w64-mingw32/bitcoin-6f0513613a98-win64-unsigned.tar.gz
86809fdb4d014e57b3137b1db9889ed68c73cce1e04f1ec837f0a121fd9315c6  guix-build-6f0513613a98/output/x86_64-w64-mingw32/bitcoin-6f0513613a98-win64.zip

@fanquake fanquake force-pushed the gcc_13_v2 branch 3 times, most recently from 8fd60e2 to 87973e5 Compare January 20, 2025 16:55
@fanquake
Copy link
Member Author

Changed the CI changes here, the win64 job is now debian:trixie, which matches Guix with GCC 13.3.0.

@@ -7,7 +7,7 @@
export LC_ALL=C.UTF-8

export CONTAINER_NAME=ci_win64
export CI_IMAGE_NAME_TAG="docker.io/debian:bookworm" # Check that https://packages.debian.org/bookworm/g++-mingw-w64-x86-64-posix (version 12.2, similar to guix) can cross-compile
export CI_IMAGE_NAME_TAG="docker.io/debian:trixie" # Check that https://packages.debian.org/trixie/g++-mingw-w64-x86-64-posix (version 13.3, similar to guix) can cross-compile
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any insurance that debian won't bump this to gcc 14 as well? Seems better to stick to 13.2, than to silently go to 14?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking this might also be needed if we want to test the newer runtime in future, but given that isn't happening yet, will just return this to nobel.

Copy link
Contributor

@TheCharlatan TheCharlatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guix build (aarch64):

b381ff87a34e45f693abee5554dd0680cb7879d66787f8aba45fb9dd149e8e78  guix-build-0c1b29a05777/output/aarch64-linux-gnu/SHA256SUMS.part
d3cb534b26ee5edd0c5d459cfffd3ebb46235da21ce2c614fda92d56f4b6ba98  guix-build-0c1b29a05777/output/aarch64-linux-gnu/bitcoin-0c1b29a05777-aarch64-linux-gnu-debug.tar.gz
b6b73fe6c3ae291e4c3d702a1343e44f3c143b50a566f1a0412dbfcf45fe31e2  guix-build-0c1b29a05777/output/aarch64-linux-gnu/bitcoin-0c1b29a05777-aarch64-linux-gnu.tar.gz
1aa98bef1d9a741e9b3e0bd306100d9fb12177267b30be23577693142710b6f6  guix-build-0c1b29a05777/output/arm-linux-gnueabihf/SHA256SUMS.part
208130deecd603ee5fa1f6dbc252a3fd5aa8498920adb94384062a45bbfcb2b6  guix-build-0c1b29a05777/output/arm-linux-gnueabihf/bitcoin-0c1b29a05777-arm-linux-gnueabihf-debug.tar.gz
90e0d50c0adf998bf24a54d7280f3af745f33fa4037e1b5584e162cf0677270f  guix-build-0c1b29a05777/output/arm-linux-gnueabihf/bitcoin-0c1b29a05777-arm-linux-gnueabihf.tar.gz
3b3887c421ae1beb8f524f56355713e09dc683cc8a801006b843d7380bfa5d48  guix-build-0c1b29a05777/output/arm64-apple-darwin/SHA256SUMS.part
1f25ea8cc64c179e68aaaadfae3cb408a790a230108f11974ab7f70359d6836a  guix-build-0c1b29a05777/output/arm64-apple-darwin/bitcoin-0c1b29a05777-arm64-apple-darwin-unsigned.tar.gz
1310af4f7e1f72100dd3e56a79ea935e712df3735e4129dbd4d905b659f4d5ad  guix-build-0c1b29a05777/output/arm64-apple-darwin/bitcoin-0c1b29a05777-arm64-apple-darwin-unsigned.zip
94165e88c22654a1e8a27070164842231901403f34b5326649ae645ab70e96d9  guix-build-0c1b29a05777/output/arm64-apple-darwin/bitcoin-0c1b29a05777-arm64-apple-darwin.tar.gz
5991b11d616c3abd2f78c2476259f103ea1a940cc77281c9d029da8f99b74906  guix-build-0c1b29a05777/output/dist-archive/bitcoin-0c1b29a05777.tar.gz
2f7c78cc66a41f94f2c6dd42caf952055b5cd5d20b2c6d93cab83a1855a103a0  guix-build-0c1b29a05777/output/powerpc64-linux-gnu/SHA256SUMS.part
38bb7a02041967e4dfb76748899c0565695a078bd112a8656fb1268365355109  guix-build-0c1b29a05777/output/powerpc64-linux-gnu/bitcoin-0c1b29a05777-powerpc64-linux-gnu-debug.tar.gz
00a8a44de3038a36174cfd8067bf39ad24962efa2cea216022cbb4e289adbcc7  guix-build-0c1b29a05777/output/powerpc64-linux-gnu/bitcoin-0c1b29a05777-powerpc64-linux-gnu.tar.gz
5f485a4ba475268b7172e215750569843e484835b98be7e2c2ed7543886c668d  guix-build-0c1b29a05777/output/riscv64-linux-gnu/SHA256SUMS.part
dd8c40507ebe0a94acfe8860278234b7687d312939938b9c5ed49667d2e74339  guix-build-0c1b29a05777/output/riscv64-linux-gnu/bitcoin-0c1b29a05777-riscv64-linux-gnu-debug.tar.gz
87151f838ccd918e28dd2fdb4729a150ad72f1c3f72f49c46fa9da4b30f2efdb  guix-build-0c1b29a05777/output/riscv64-linux-gnu/bitcoin-0c1b29a05777-riscv64-linux-gnu.tar.gz
b237b88534fab0314d652b66514053af3b18ba798fac353a3a0a5482ee07cf7c  guix-build-0c1b29a05777/output/x86_64-apple-darwin/SHA256SUMS.part
ded3d046f842a6d532c45dfb465e23e23c2c94f8f58e0047aaa5d0a7ffbadd65  guix-build-0c1b29a05777/output/x86_64-apple-darwin/bitcoin-0c1b29a05777-x86_64-apple-darwin-unsigned.tar.gz
5da4593213c0b9eac24b8e8eb2faa536899a1f9dec64aae2189e7507a844a2a3  guix-build-0c1b29a05777/output/x86_64-apple-darwin/bitcoin-0c1b29a05777-x86_64-apple-darwin-unsigned.zip
96e998f7ee34bafabe7273e12412045d9227a96dc4b37dba8a25969a3b6856bc  guix-build-0c1b29a05777/output/x86_64-apple-darwin/bitcoin-0c1b29a05777-x86_64-apple-darwin.tar.gz
63eef56512820eb91cb961212ec55b8994afcfe9526dbb25d9bae9b244339496  guix-build-0c1b29a05777/output/x86_64-linux-gnu/SHA256SUMS.part
d0bd954da5c64064745c1bde9e8462b0ebb05787801b4b1fd7087f0a0d4c1870  guix-build-0c1b29a05777/output/x86_64-linux-gnu/bitcoin-0c1b29a05777-x86_64-linux-gnu-debug.tar.gz
2536953874c70adb5c9a3dd7a14229c96533ee00465c212d0271f43a173608ec  guix-build-0c1b29a05777/output/x86_64-linux-gnu/bitcoin-0c1b29a05777-x86_64-linux-gnu.tar.gz
31bdd0d8012adcb017fb23805a788e724ea437854463cd96f97b75eb2382f6be  guix-build-0c1b29a05777/output/x86_64-w64-mingw32/SHA256SUMS.part
2712d61c07ab7c7298244dc83d870c7e934055d20581ae0a1ae45eccb3db3842  guix-build-0c1b29a05777/output/x86_64-w64-mingw32/bitcoin-0c1b29a05777-win64-debug.zip
59cc8134cb597f9c8075eb1a8e3b13a95f60bbd452bbe0b67baf933034f54c25  guix-build-0c1b29a05777/output/x86_64-w64-mingw32/bitcoin-0c1b29a05777-win64-setup-unsigned.exe
c6527bca15c54d0e18aa392f5a3609844d53772604508ccd3dffe6730aab8700  guix-build-0c1b29a05777/output/x86_64-w64-mingw32/bitcoin-0c1b29a05777-win64-unsigned.tar.gz
786f68ee33e8d075be0d2e1cccd05ebf64d196ba5d7eb3e429ab8581f41c0a6a  guix-build-0c1b29a05777/output/x86_64-w64-mingw32/bitcoin-0c1b29a05777-win64.zip

@hebasto
Copy link
Member

hebasto commented Jan 22, 2025

My Guix build:

riscv64
b381ff87a34e45f693abee5554dd0680cb7879d66787f8aba45fb9dd149e8e78  guix-build-0c1b29a05777/output/aarch64-linux-gnu/SHA256SUMS.part
d3cb534b26ee5edd0c5d459cfffd3ebb46235da21ce2c614fda92d56f4b6ba98  guix-build-0c1b29a05777/output/aarch64-linux-gnu/bitcoin-0c1b29a05777-aarch64-linux-gnu-debug.tar.gz
b6b73fe6c3ae291e4c3d702a1343e44f3c143b50a566f1a0412dbfcf45fe31e2  guix-build-0c1b29a05777/output/aarch64-linux-gnu/bitcoin-0c1b29a05777-aarch64-linux-gnu.tar.gz
1aa98bef1d9a741e9b3e0bd306100d9fb12177267b30be23577693142710b6f6  guix-build-0c1b29a05777/output/arm-linux-gnueabihf/SHA256SUMS.part
208130deecd603ee5fa1f6dbc252a3fd5aa8498920adb94384062a45bbfcb2b6  guix-build-0c1b29a05777/output/arm-linux-gnueabihf/bitcoin-0c1b29a05777-arm-linux-gnueabihf-debug.tar.gz
90e0d50c0adf998bf24a54d7280f3af745f33fa4037e1b5584e162cf0677270f  guix-build-0c1b29a05777/output/arm-linux-gnueabihf/bitcoin-0c1b29a05777-arm-linux-gnueabihf.tar.gz
3b3887c421ae1beb8f524f56355713e09dc683cc8a801006b843d7380bfa5d48  guix-build-0c1b29a05777/output/arm64-apple-darwin/SHA256SUMS.part
1f25ea8cc64c179e68aaaadfae3cb408a790a230108f11974ab7f70359d6836a  guix-build-0c1b29a05777/output/arm64-apple-darwin/bitcoin-0c1b29a05777-arm64-apple-darwin-unsigned.tar.gz
1310af4f7e1f72100dd3e56a79ea935e712df3735e4129dbd4d905b659f4d5ad  guix-build-0c1b29a05777/output/arm64-apple-darwin/bitcoin-0c1b29a05777-arm64-apple-darwin-unsigned.zip
94165e88c22654a1e8a27070164842231901403f34b5326649ae645ab70e96d9  guix-build-0c1b29a05777/output/arm64-apple-darwin/bitcoin-0c1b29a05777-arm64-apple-darwin.tar.gz
5991b11d616c3abd2f78c2476259f103ea1a940cc77281c9d029da8f99b74906  guix-build-0c1b29a05777/output/dist-archive/bitcoin-0c1b29a05777.tar.gz
2f7c78cc66a41f94f2c6dd42caf952055b5cd5d20b2c6d93cab83a1855a103a0  guix-build-0c1b29a05777/output/powerpc64-linux-gnu/SHA256SUMS.part
38bb7a02041967e4dfb76748899c0565695a078bd112a8656fb1268365355109  guix-build-0c1b29a05777/output/powerpc64-linux-gnu/bitcoin-0c1b29a05777-powerpc64-linux-gnu-debug.tar.gz
00a8a44de3038a36174cfd8067bf39ad24962efa2cea216022cbb4e289adbcc7  guix-build-0c1b29a05777/output/powerpc64-linux-gnu/bitcoin-0c1b29a05777-powerpc64-linux-gnu.tar.gz
5f485a4ba475268b7172e215750569843e484835b98be7e2c2ed7543886c668d  guix-build-0c1b29a05777/output/riscv64-linux-gnu/SHA256SUMS.part
dd8c40507ebe0a94acfe8860278234b7687d312939938b9c5ed49667d2e74339  guix-build-0c1b29a05777/output/riscv64-linux-gnu/bitcoin-0c1b29a05777-riscv64-linux-gnu-debug.tar.gz
87151f838ccd918e28dd2fdb4729a150ad72f1c3f72f49c46fa9da4b30f2efdb  guix-build-0c1b29a05777/output/riscv64-linux-gnu/bitcoin-0c1b29a05777-riscv64-linux-gnu.tar.gz
b237b88534fab0314d652b66514053af3b18ba798fac353a3a0a5482ee07cf7c  guix-build-0c1b29a05777/output/x86_64-apple-darwin/SHA256SUMS.part
ded3d046f842a6d532c45dfb465e23e23c2c94f8f58e0047aaa5d0a7ffbadd65  guix-build-0c1b29a05777/output/x86_64-apple-darwin/bitcoin-0c1b29a05777-x86_64-apple-darwin-unsigned.tar.gz
5da4593213c0b9eac24b8e8eb2faa536899a1f9dec64aae2189e7507a844a2a3  guix-build-0c1b29a05777/output/x86_64-apple-darwin/bitcoin-0c1b29a05777-x86_64-apple-darwin-unsigned.zip
96e998f7ee34bafabe7273e12412045d9227a96dc4b37dba8a25969a3b6856bc  guix-build-0c1b29a05777/output/x86_64-apple-darwin/bitcoin-0c1b29a05777-x86_64-apple-darwin.tar.gz
63eef56512820eb91cb961212ec55b8994afcfe9526dbb25d9bae9b244339496  guix-build-0c1b29a05777/output/x86_64-linux-gnu/SHA256SUMS.part
d0bd954da5c64064745c1bde9e8462b0ebb05787801b4b1fd7087f0a0d4c1870  guix-build-0c1b29a05777/output/x86_64-linux-gnu/bitcoin-0c1b29a05777-x86_64-linux-gnu-debug.tar.gz
2536953874c70adb5c9a3dd7a14229c96533ee00465c212d0271f43a173608ec  guix-build-0c1b29a05777/output/x86_64-linux-gnu/bitcoin-0c1b29a05777-x86_64-linux-gnu.tar.gz
31bdd0d8012adcb017fb23805a788e724ea437854463cd96f97b75eb2382f6be  guix-build-0c1b29a05777/output/x86_64-w64-mingw32/SHA256SUMS.part
2712d61c07ab7c7298244dc83d870c7e934055d20581ae0a1ae45eccb3db3842  guix-build-0c1b29a05777/output/x86_64-w64-mingw32/bitcoin-0c1b29a05777-win64-debug.zip
59cc8134cb597f9c8075eb1a8e3b13a95f60bbd452bbe0b67baf933034f54c25  guix-build-0c1b29a05777/output/x86_64-w64-mingw32/bitcoin-0c1b29a05777-win64-setup-unsigned.exe
c6527bca15c54d0e18aa392f5a3609844d53772604508ccd3dffe6730aab8700  guix-build-0c1b29a05777/output/x86_64-w64-mingw32/bitcoin-0c1b29a05777-win64-unsigned.tar.gz
786f68ee33e8d075be0d2e1cccd05ebf64d196ba5d7eb3e429ab8581f41c0a6a  guix-build-0c1b29a05777/output/x86_64-w64-mingw32/bitcoin-0c1b29a05777-win64.zip

@@ -7,7 +7,7 @@
export LC_ALL=C.UTF-8

export CONTAINER_NAME=ci_win64
export CI_IMAGE_NAME_TAG="docker.io/debian:bookworm" # Check that https://packages.debian.org/bookworm/g++-mingw-w64-x86-64-posix (version 12.2, similar to guix) can cross-compile
export CI_IMAGE_NAME_TAG="docker.io/ubuntu:noble" # Check that g++-mingw-w64-x86-64-posix (version 13.2, similar to guix) can cross-compile
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Why not keep a full URL, as in other places?

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 0c1b29a.

Copy link
Contributor

@TheCharlatan TheCharlatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-ACK 0c1b29a

@achow101
Copy link
Member

ACK 0c1b29a

b381ff87a34e45f693abee5554dd0680cb7879d66787f8aba45fb9dd149e8e78  guix-build-0c1b29a05777/output/aarch64-linux-gnu/SHA256SUMS.part
d3cb534b26ee5edd0c5d459cfffd3ebb46235da21ce2c614fda92d56f4b6ba98  guix-build-0c1b29a05777/output/aarch64-linux-gnu/bitcoin-0c1b29a05777-aarch64-linux-gnu-debug.tar.gz
b6b73fe6c3ae291e4c3d702a1343e44f3c143b50a566f1a0412dbfcf45fe31e2  guix-build-0c1b29a05777/output/aarch64-linux-gnu/bitcoin-0c1b29a05777-aarch64-linux-gnu.tar.gz
1aa98bef1d9a741e9b3e0bd306100d9fb12177267b30be23577693142710b6f6  guix-build-0c1b29a05777/output/arm-linux-gnueabihf/SHA256SUMS.part
208130deecd603ee5fa1f6dbc252a3fd5aa8498920adb94384062a45bbfcb2b6  guix-build-0c1b29a05777/output/arm-linux-gnueabihf/bitcoin-0c1b29a05777-arm-linux-gnueabihf-debug.tar.gz
90e0d50c0adf998bf24a54d7280f3af745f33fa4037e1b5584e162cf0677270f  guix-build-0c1b29a05777/output/arm-linux-gnueabihf/bitcoin-0c1b29a05777-arm-linux-gnueabihf.tar.gz
3b3887c421ae1beb8f524f56355713e09dc683cc8a801006b843d7380bfa5d48  guix-build-0c1b29a05777/output/arm64-apple-darwin/SHA256SUMS.part
1f25ea8cc64c179e68aaaadfae3cb408a790a230108f11974ab7f70359d6836a  guix-build-0c1b29a05777/output/arm64-apple-darwin/bitcoin-0c1b29a05777-arm64-apple-darwin-unsigned.tar.gz
1310af4f7e1f72100dd3e56a79ea935e712df3735e4129dbd4d905b659f4d5ad  guix-build-0c1b29a05777/output/arm64-apple-darwin/bitcoin-0c1b29a05777-arm64-apple-darwin-unsigned.zip
94165e88c22654a1e8a27070164842231901403f34b5326649ae645ab70e96d9  guix-build-0c1b29a05777/output/arm64-apple-darwin/bitcoin-0c1b29a05777-arm64-apple-darwin.tar.gz
5991b11d616c3abd2f78c2476259f103ea1a940cc77281c9d029da8f99b74906  guix-build-0c1b29a05777/output/dist-archive/bitcoin-0c1b29a05777.tar.gz
2f7c78cc66a41f94f2c6dd42caf952055b5cd5d20b2c6d93cab83a1855a103a0  guix-build-0c1b29a05777/output/powerpc64-linux-gnu/SHA256SUMS.part
38bb7a02041967e4dfb76748899c0565695a078bd112a8656fb1268365355109  guix-build-0c1b29a05777/output/powerpc64-linux-gnu/bitcoin-0c1b29a05777-powerpc64-linux-gnu-debug.tar.gz
00a8a44de3038a36174cfd8067bf39ad24962efa2cea216022cbb4e289adbcc7  guix-build-0c1b29a05777/output/powerpc64-linux-gnu/bitcoin-0c1b29a05777-powerpc64-linux-gnu.tar.gz
5f485a4ba475268b7172e215750569843e484835b98be7e2c2ed7543886c668d  guix-build-0c1b29a05777/output/riscv64-linux-gnu/SHA256SUMS.part
dd8c40507ebe0a94acfe8860278234b7687d312939938b9c5ed49667d2e74339  guix-build-0c1b29a05777/output/riscv64-linux-gnu/bitcoin-0c1b29a05777-riscv64-linux-gnu-debug.tar.gz
87151f838ccd918e28dd2fdb4729a150ad72f1c3f72f49c46fa9da4b30f2efdb  guix-build-0c1b29a05777/output/riscv64-linux-gnu/bitcoin-0c1b29a05777-riscv64-linux-gnu.tar.gz
b237b88534fab0314d652b66514053af3b18ba798fac353a3a0a5482ee07cf7c  guix-build-0c1b29a05777/output/x86_64-apple-darwin/SHA256SUMS.part
ded3d046f842a6d532c45dfb465e23e23c2c94f8f58e0047aaa5d0a7ffbadd65  guix-build-0c1b29a05777/output/x86_64-apple-darwin/bitcoin-0c1b29a05777-x86_64-apple-darwin-unsigned.tar.gz
5da4593213c0b9eac24b8e8eb2faa536899a1f9dec64aae2189e7507a844a2a3  guix-build-0c1b29a05777/output/x86_64-apple-darwin/bitcoin-0c1b29a05777-x86_64-apple-darwin-unsigned.zip
96e998f7ee34bafabe7273e12412045d9227a96dc4b37dba8a25969a3b6856bc  guix-build-0c1b29a05777/output/x86_64-apple-darwin/bitcoin-0c1b29a05777-x86_64-apple-darwin.tar.gz
63eef56512820eb91cb961212ec55b8994afcfe9526dbb25d9bae9b244339496  guix-build-0c1b29a05777/output/x86_64-linux-gnu/SHA256SUMS.part
d0bd954da5c64064745c1bde9e8462b0ebb05787801b4b1fd7087f0a0d4c1870  guix-build-0c1b29a05777/output/x86_64-linux-gnu/bitcoin-0c1b29a05777-x86_64-linux-gnu-debug.tar.gz
2536953874c70adb5c9a3dd7a14229c96533ee00465c212d0271f43a173608ec  guix-build-0c1b29a05777/output/x86_64-linux-gnu/bitcoin-0c1b29a05777-x86_64-linux-gnu.tar.gz
31bdd0d8012adcb017fb23805a788e724ea437854463cd96f97b75eb2382f6be  guix-build-0c1b29a05777/output/x86_64-w64-mingw32/SHA256SUMS.part
2712d61c07ab7c7298244dc83d870c7e934055d20581ae0a1ae45eccb3db3842  guix-build-0c1b29a05777/output/x86_64-w64-mingw32/bitcoin-0c1b29a05777-win64-debug.zip
59cc8134cb597f9c8075eb1a8e3b13a95f60bbd452bbe0b67baf933034f54c25  guix-build-0c1b29a05777/output/x86_64-w64-mingw32/bitcoin-0c1b29a05777-win64-setup-unsigned.exe
c6527bca15c54d0e18aa392f5a3609844d53772604508ccd3dffe6730aab8700  guix-build-0c1b29a05777/output/x86_64-w64-mingw32/bitcoin-0c1b29a05777-win64-unsigned.tar.gz
786f68ee33e8d075be0d2e1cccd05ebf64d196ba5d7eb3e429ab8581f41c0a6a  guix-build-0c1b29a05777/output/x86_64-w64-mingw32/bitcoin-0c1b29a05777-win64.zip

@achow101 achow101 merged commit 785649f into bitcoin:master Feb 19, 2025
18 checks passed
@fanquake fanquake deleted the gcc_13_v2 branch February 19, 2025 21:20
TheCharlatan added a commit to TheCharlatan/rust-bitcoinkernel that referenced this pull request Feb 22, 2025
…513955891

29513955891 kernel: Add pure kernel bitcoin-chainstate
9c40433bd4a kernel: Add functions to get the block hash from a block
942df8f287f kernel: Add block index utility functions to C header
87102db87ac kernel: Add function to read block undo data from disk to C header
12b8c9442ad kernel: Add functions to read block from disk to C header
d977db3feb2 kernel: Add function for copying  block data to C header
8ae33627743 kernel: Add functions for the block validation state to C header
0565a0bbc01 kernel: Add validation interface to C header
837e5a0f536 kernel: Add interrupt function to C header
a80b7bfe3de kernel: Add import blocks function to C header
54d1a1231ec kernel: Add chainstate load options for in-memory dbs in C header
659efa9969c kernel: Add options for reindexing in C header
2179127c079 kernel: Add block validation to C header
26143992693 kernel: Add chainstate loading when instantiating a ChainstateManager
82d2bebbe54 kernel: Add chainstate manager option for setting worker threads
e875f520851 kernel: Add chainstate manager object to C header
4e486059178 kernel: Add notifications context option to C header
a5eb699b978 kernel: Add chain params context option to C header
0818b8d2c07 kernel: Add kernel library context object
71c24c95b31 kernel: Add logging to kernel library C header
0cc810386f7 kernel: Introduce initial kernel C header API
82ba9257157 Merge bitcoin/bitcoin#31366: cmake: Check `-Wno-*` compiler options for `leveldb` target
f236854a5bd Merge bitcoin/bitcoin#31731: doc: update translation generation cmake example
eb51963d870 Merge bitcoin/bitcoin#31884: cmake: Make implicit `libbitcoinkernel` dependencies explicit
58f15d4b215 Merge bitcoin/bitcoin#31379: cmake: Fix passing `APPEND_*FLAGS` to `secp256k1` subtree
e606c577cb2 Merge bitcoin/bitcoin#31899: cmake: Exclude generated sources from translation
758a93d6215 doc: update translation generation cmake example
fd14995b6a8 Merge bitcoin/bitcoin#31908: Revert merge of PR #31826
3e9b12b3e0f Revert "Merge bitcoin/bitcoin#31826: random: Check `GetRNDRRS` is supported in `InitHardwareRand` to avoid infinite loop"
785649f3977 Merge bitcoin/bitcoin#29881: guix: use GCC 13 to build releases
139640079ff Merge bitcoin/bitcoin#31826: random: Check `GetRNDRRS` is supported in `InitHardwareRand` to avoid infinite loop
dc3a7146337 Merge bitcoin/bitcoin#31794: wallet: abandon orphan coinbase txs, and their descendants, during startup
06757af2da5 Merge bitcoin/bitcoin#29156: tests: add functional test for miniscript decaying multisig
ff4ddd3d2e3 Revert "cmake: Ensure generated sources are up to date for `translate` target"
03b3166aac5 cmake: Exclude generated sources from translation
43e287b3ff5 Merge bitcoin/bitcoin#31892: build: remove ENABLE_HARDENING condition from check-security
63d625f7610 Merge bitcoin/bitcoin#31893: test: remove scanning check on `wallet_importdescriptors`
3b42e05aa9e cmake: Make implicit `libbitcoinkernel` dependencies explicit
3fd64efb437 cmake: Avoid using `OBJECT` libraries
28dec6c5f8b Merge bitcoin/bitcoin#31268: cmake: add optional source files to bitcoin_crypto and crc32c directly
50afaf3a389 Merge bitcoin/bitcoin#31836: contrib: Add deterministic-fuzz-coverage
405dd0e647e test: remove scanning check on `wallet_importdescriptors`
113a7a363fa build: remove ENABLE_HARDENING cond from check-security
9da0820ec55 Merge bitcoin/bitcoin#31869: cmake: Add `libbitcoinkernel` target
db36a92c02b Merge bitcoin/bitcoin#31879: doc: add release note for #27432 (utxo-to-sqlite tool)
95722d048a8 doc: add release note for #27432 (utxo-to-sqlite tool)
e4dd5a351bd test: wallet, abandon coinbase txs and their descendants during startup
09b150bb8ad In `InitHardwareRand`, do trail test for `RNDRRS` by `VerifyRNDRRS`
43e71f74988 Merge bitcoin/bitcoin#27432: contrib: add tool to convert compact-serialized UTXO set to SQLite database
e53310c47ab Merge bitcoin/bitcoin#30529: Fix -norpcwhitelist, -norpcallowip, and similar corner case behavior
254fd89d39f Merge bitcoin/bitcoin#31863: random: Initialize variables in hardware RNG functions
75f8396c907 Merge bitcoin/bitcoin#30746: test: cover base[32|58|64] with symmetric roundtrip fuzz (and padding) tests
c4b46b45898 Merge bitcoin/bitcoin#31629: wallet: fix rescanning inconsistency
d0dfd6d3f60 Merge bitcoin/bitcoin#31865: build: move `rpc/external_signer` to node library
ce4dbfc3590 Merge bitcoin/bitcoin#31851: doc: build: Fix instructions for msvc gui builds
504d0c21e26 Merge bitcoin/bitcoin#31439: validation: In case of a continued reindex, only activate chain in the end
0b48f77e101 Merge bitcoin/bitcoin#31413: rpc: Remove deprecated dummy alias for listtransactions::label
21a0efaf8c9 Merge bitcoin/bitcoin#29858: test: Add test for rpcwhitelistdefault
8a00b755e98 Merge bitcoin/bitcoin#31634: doc: Improve dependencies documentation
e58605e04f3 Merge bitcoin/bitcoin#31854: net: reduce CAddress usage to CService or CNetAddr
3a914ab96bd cmake: Rename `bitcoinkernel` component to `libbitcoinkernel`
06b9236f432 Merge bitcoin/bitcoin#31359: cmake: Add `CheckLinkerSupportsPIE` module
7ce09a59921 cmake: Add `libbitcoinkernel` target
e501246e77c build: move rpc/external_signer to node library
73e2ec13737 Merge bitcoin/bitcoin#31844: cmake: add a component for each binary
99755e04ffa random: Initialize variables in hardware RNG functions
7bbd761e816 Merge bitcoin/bitcoin#31421: cmake: Improve compatibility with Python version managers
9491676438a Merge bitcoin/bitcoin#31157: Cleanups to port mapping module post UPnP drop
109bfe9573b Merge bitcoin/bitcoin#31857: depends: avoid an unset `CMAKE_OBJDUMP`
14d1d8e2120 Merge bitcoin/bitcoin#31758: test: deduplicates p2p_tx_download constants
fa3e409c9a0 contrib: Add deterministic-fuzz-coverage
2549fc6fd1c Merge bitcoin/bitcoin#31768: test: check `scanning` field from `getwalletinfo`
9b033bebb18 cmake: rename Kernel component to bitcoinkernel for consistency
2e0c92558e9 cmake: add and use install_binary_component
a85e8c0e615 doc: Add some general documentation about negated options
96d30ed4f96 Merge bitcoin/bitcoin#31495: wallet: Utilize IsMine() and CanProvide() in migration to cover edge cases
490c8fa1782 doc: Add release notes summarizing negated option behavior changes.
458ef0a11b5 refactor: Avoid using IsArgSet() on -connect list option
752ab9c3c65 test: Add test to make sure -noconnect disables -dnsseed and -listen by default
3c2920ec98f refactor: Avoid using IsArgSet() on -signetseednode and -signetchallenge list options
d05668922a2 refactor: Avoid using IsArgSet() on -debug, -loglevel, and -vbparams list options
3d1e8ca53a0 Normalize inconsistent -noexternalip behavior
ecd590d4c1e Normalize inconsistent -noonlynet behavior
5544a19f863 Fix nonsensical bitcoin-cli -norpcwallet behavior
6e8e7f433fc Fix nonsensical -noasmap behavior
b6ab3508064 Fix nonsensical -notest behavior
6768389917a Fix nonsensical -norpcwhitelist behavior
e03409c70f7 Fix nonsensical -norpcbind and -norpcallowip behavior
40c4899bc20 Fix nonsensical -nobind and -nowhitebind behavior
5453e66fd91 Fix nonsensical -noseednode behavior
c242fa5be35 Merge bitcoin/bitcoin#31858: chore: remove redundant word
4c62b37fcd2 chore: remove redundant word
251ea7367cf Merge bitcoin/bitcoin#31767: logging: Ensure -debug=0/none behaves consistently with -nodebug
2434aeab62b depends: avoid an unset CMAKE_OBJDUMP
a5b0a441f85 Merge bitcoin/bitcoin#31855: chore: remove redundant word
cd4bfaee103 net: reduce CAddress usage to CService or CNetAddr
033acdf03da chore: remove redundant word
55cf39e4c54 Merge bitcoin/bitcoin#31722: cmake: Copy `cov_tool_wrapper.sh.in` to the build tree
c3fa043ae56 doc: build: Fix instructions for msvc gui builds
048ef98626b Merge bitcoin/bitcoin#31840: depends: add missing Darwin objcopy
713bf66b1f7 Merge bitcoin/bitcoin#31500: depends: Fix compiling `libevent` package on NetBSD
ede388d03df Merge bitcoin/bitcoin#30911: build: simplify by flattening the dependency graph
534414ca9d4 Merge bitcoin/bitcoin#31678: ci: Skip read-write of default env vars
87ce116058f Merge bitcoin/bitcoin#31846: test: Remove stale gettime test
fa3a4eafa11 test: Remove stale gettime test
42251e00e8b Merge bitcoin/bitcoin#30584: depends: Make default `host` and `build` comparable
0b6ed342b57 Merge bitcoin/bitcoin#31711: build: set build type and per-build-type flags as early as possible
a44ccedcc2c Merge bitcoin/bitcoin#31818: guix: remove test-security/symbol-check scripts
0264c5d86c7 cmake: use per-target components for bitcoin-qt and bitcoin-gui
fb0546b1c5e ci: don't try to install for a fuzz build
c65233230f1 Merge bitcoin/bitcoin#31022: test: Add mockable steady clock, tests for PCP and NATPMP implementations
86528937e5c Merge bitcoin/bitcoin#31834: build: disable bitcoin-node if daemon is not built
7afeaa24693 test: `-debug=0` and `-debug=none` behave similarly to `-nodebug`
a8fedb36a71 logging: Ensure -debug=0/none behaves consistently with -nodebug
d39d521d86a test: `-nodebug` clears previously set debug options
3edaf0b4286 depends: add missing Darwin objcopy
2507ebdf1b2 Merge bitcoin/bitcoin#31837: test: add missing sync to p2p_tx_download.py
79f02d56ef7 Merge bitcoin/bitcoin#30623: test: Fuzz the human-readable part of bech32 as well
ff3171f96d3 Merge bitcoin/bitcoin#31614: test: expect that files may disappear from /proc/PID/fd/
56a9b847bba build: set build type and per-build-type flags as early as possible
8fe552fe6e0 test: add missing sync to p2p_tx_download.py
af76664b12d test: Test migration of a solvable script with no privkeys
17f01b0795e test: Test migration of taproot output scripts
1eb9a2a39fd test: Test migration of miniscript in legacy wallets
e8c3efc7d8f wallet migration: Determine Solvables with CanProvide
fa1b7cd6e2c migration: Skip descriptors which do not parse
440ea1ab639 legacy spkm: use IsMine() to extract watched output scripts
b777e84cd70 legacy spkm: Move CanProvide to LegacyDataSPKM
b1ab927bbf2 tests: Test migration of additional P2WSH scripts
1d813e4bf52 Merge bitcoin/bitcoin#31819: doc: swap CPPFLAGS for APPEND_CPPFLAGS
2ffea09820e build: disable bitcoin-node if daemon is not built
f8d3e0edf47 Merge bitcoin/bitcoin#30205: test: add mocked Sock that can read/write custom data and/or CNetMessages
6b165f5906f Merge bitcoin/bitcoin#31384: mining: bugfix: Fix duplicate coinbase tx weight reservation
6a46be75c43 Merge bitcoin/bitcoin#31793: ci: Use clang-20 for sanitizer tasks
76c090145e9 guix: remove test-security/symbol-check scripts
329b60f595e Merge bitcoin/bitcoin#31810: TxOrphanage: account for size of orphans and count announcements
bc3f59ca530 Merge bitcoin/bitcoin#31820: build: consistently use `CLIENT_NAME` in libbitcoinkernel.pc.in
dead9086543 cmake: Improve compatibility with Python version managers
e107bf78f9d [fuzz] TxOrphanage::SanityCheck accounting
fb0ada982a7 Merge bitcoin/bitcoin#31811: test: test_inv_block, use mocktime instead of waiting
f5b9a2f68c9 build: use CLIENT_NAME in libbitcoinkernel.pc.in
ea687d20293 doc: swap CPPFLAGS for APPEND_CPPFLAGS
81eb6cc2c60 Merge bitcoin/bitcoin#31800: depends: Avoid using the `-ffile-prefix-map` compiler option
2f98d1e06ed Merge bitcoin/bitcoin#31814: ci: Bump fuzz task timeout
9cf746d6631 cmake: add optional source files to crc32c directly
9c7823c5b53 cmake: add optional source files to bitcoin_crypto directly
faca7ac1321 ci: Bump fuzz task timeout
22dccea5532 [fuzz] txorphan byte accounting
982ce101781 add orphanage byte accounting to TxDownloadManagerImpl::CheckIsEmpty()
c289217c014 [txorphanage] track the total number of announcements
e5ea7daee01 [txorphanage] add per-peer weight accounting
672c69c688f [refactor] change per-peer workset to info map within orphanage
59cd0f0e091 [txorphanage] account for weight of orphans
f93d6cb0caa Merge bitcoin/bitcoin#31809: Prepare "Open Transifex translations for v29.0" release step
f605f7a9c26 build: refactor: set debug definitions in main CMakeLists
2706c5b7c8e test: test_inv_block, use mocktime instead of waiting
0a02e7fdeac test: deduplicates p2p_tx_download constants
2f27c910869 qt: Update the `src/qt/locale/bitcoin_en.xlf` translation source file
864386a7444 cmake: Ensure generated sources are up to date for `translate` target
d6c229d8bd4 Merge bitcoin/bitcoin#31804: ci: Remove no longer needed `-Wno-error=documentation`
2b51dd384b4 Update Transifex slug for 29.x
82ba5051342 Merge bitcoin/bitcoin#31759: test: fixes p2p_ibd_txrelay wait time
ae9eaa063b6 Merge bitcoin/bitcoin#31760: test: make sure we are on sync with a peer before checking if they have sent a message
f1d7a6dfa14 ci: Remove no longer needed '-Wno-error=documentation'
a43f08c4ae3 Merge bitcoin/bitcoin#25832: tracing: network connection tracepoints
407062f2ac9 depends: Avoid using the `-ffile-prefix-map` compiler option
b9c241804c0 Merge bitcoin/bitcoin#30226: test: add validation for gettxout RPC response
1334ca6c070 Merge bitcoin/bitcoin#31437: func test: Expand tx download preference tests
33932d30e38 Merge bitcoin/bitcoin#31784: test: added additional coverage to waitforblock and waitforblockheight rpc's
2aa7be1744a Merge bitcoin/bitcoin#31358: depends: Avoid hardcoding `host_prefix` in toolchain file
386eecff5f1 doc: add release notes
3eaa0a3b663 miner: init: add `-blockreservedweight` startup option
777434a2cd1 doc: rpc: improve `getmininginfo` help text
c8acd4032d5 init: fail to start when `-blockmaxweight` exceeds `MAX_BLOCK_WEIGHT`
5bb31633cc9 test: add `-blockmaxweight` startup option functional test
2c7d90a6d67 miner: bugfix: fix duplicate weight reservation in block assembler
fa5a02bcfa2 ci: Use clang-20 for sanitizer tasks
474139aa9bf wallet: abandon inactive coinbase tx and their descendants during startup
bb0879ddabc test: check `scanning` field from `getwalletinfo`
94ca99ac51d Merge bitcoin/bitcoin#31666: multi-peer orphan resolution followups
6f5ae1a5745 Merge bitcoin/bitcoin#31653: lint: Call more checks from test_runner
e3622a96929 tracing: document that peer addrs can be >68 chars
b19b526758f tracing: log_p2p_connections.bt example
caa5486574b tracing: connection closed tracepoint
b2ad6ede95e tracing: add misbehaving conn tracepoint
68c1ef4f19b tracing: add inbound connection eviction tracepoint
4d61d52f438 tracing: add outbound connection tracepoint
85b2603eec6 tracing: add inbound connection tracepoint
7e0db87d4ff test: added additional coverage to waitforblock and waitforblockheight rpc's
f89f16846ec depends: Fix compiling `libevent` package on NetBSD
1172bc4157e Merge bitcoin-core/gui#850: psbt: Use SIGHASH_DEFAULT when signing PSBTs
12fa9511b5f build: simplify dependency graph
c4e498300c7 build: avoid unnecessary dependencies on generated headers
7426afbe624 [p2p] assign just 1 random announcer in AddChildrenToWorkSet
4c1fa6b28c2 test fix: make peer who sends MSG_TX announcement non-wtxidrelay
2da46b88f09 pass P2PTxInvStore init args to P2PInterface init
e3bd51e4b52 [doc] how unique_parents can be empty
32eb6dc758a [refactor] assign local variable for wtxid
18820ccf6b2 multi-announcer orphan handling test fixups
c4cc61db98f [fuzz] GetCandidatePeers
7704139cf0d [refactor] make GetCandidatePeers take uint256 and in-out vector
6e4d392a753 [refactor] rename to OrphanResolutionCandidate to MaybeAdd*
57221ad9797 [refactor] move parent inv-adding to OrphanResolutionCandidate
3f4b104b1b7 test: make sure we are on sync with a peer before checking if they have sent a message
1973a9e4f1d test: fixes p2p_ibd_txrelay wait time
723440c5b8e test framework, wallet: rename get_scriptPubKey method to get_output_script
fa0232a3e07 test: add validation for gettxout RPC response
81c174e3186 cmake: Refer to the configure log instead of printing PIE test error
e3c01527696 cmake: Copy `cov_tool_wrapper.sh.in` to the build tree
faf8fc5487d lint: Call lint_commit_msg from test_runner
fa99728b0c8 lint: Move commit range printing to test_runner
fa673cf3449 lint: Call lint_scripted_diff from test_runner
bb633c9407c tests: add functional test for miniscript decaying multisig
c39b3cfcd1b test: Extra verification that migratewallet migrates
0c1b29a0577 ci: use GCC 13 for some jobs
cbc65b3ad5a guix: use GCC 13.3.0 for base toolchain.
fa952acdb6e ci: Skip read-write of default env vars
a759ea3e920 doc: Improve dependencies documentation
f0e5e4cdbec test: Add test for rpcwhitelistdefault
0f716f28896 qa: cover PROTOCOL_ERROR variant in PCP unit tests
fc700bb47fd test: Add tests for PCP and NATPMP implementations
65a0920ca6b cmake: Add `CheckLinkerSupportsPIE` module
caf95210331 net: Use mockable steady clock in PCP implementation
03648321ecb util: Add mockable steady_clock
ab1d3ece026 net: Add optional length checking to CService::SetSockAddr
4818da809f0 wallet: fix rescanning inconsistency
b2e9fdc00f5 test: expect that files may disappear from /proc/PID/fd/
3e97ff9c5ea gui, psbt: Use SIGHASH_DEFAULT when signing PSBTs
f919d919eb8 fuzz: Add fuzzing for max_ret_len in DecodeBase58/DecodeBase58Check
635bc58f46b test: Fuzz Base32/Base58/Base64 roundtrip conversions
5dd3a0d8a89 test: Extend base58_encode_decode.json with edge cases
ae40cf1a8e1 test: Add padding tests for Base32/Base64
4080b66cbec test: add test for utxo-to-sqlite conversion script
ec99ed73808 contrib: add tool to convert compact-serialized UTXO set to SQLite database
b448b014947 test: add a mocked Sock that allows inspecting what has been Send() to it
f1864148c4a test: put the generic parts from StaticContentsSock into a separate class
c9136ca9060 validation: fix issue with an interrupted -reindex
a2675897e2a validation: Don't loop over all chainstates in LoadExternalBlock
846a1387280 func test: Expand tx download preference tests
c4c5cf17488 cmake: Fix passing `APPEND_*FLAGS` to `secp256k1` subtree
eb540a26295 cmake: Remove `core_sanitizer_{cxx,linker}_flags` helper variables
fa8e0956c23 rpc: Remove deprecated dummy alias for listtransactions::label
9e4a4b48322 cmake: Check `-Wno-*` compiler options for `leveldb` target
d9c8aacce38 depends, refactor: Avoid hardcoding `host_prefix` in toolchain file
4b58d55878d test: move the implementation of StaticContentsSock to .cpp
70398ae05bc mapport: make ProcessPCP void
9e6cba29882 mapport: remove unnecessary 'g_mapport_enabled'
8fb45fcda07 mapport: remove unnecessary 'g_mapport_current' variable
1b223cb19b4 mapport: merge DispatchMapPort into StartMapPort
9bd936fa34a mapport: drop unnecessary function
2a6536ceda7 mapport: rename 'use_pcp' to 'enable'
c4e82b854cd mapport: make 'enabled' and 'current' bool
9b7023d31a3 Fuzz HRP of bech32 as well
c1a5d5c100b Split out bech32 separator char to header
b28917be363 depends: Make default `host` and `build` comparable
REVERT: 5aeaa3f49d1 kernel: Add pure kernel bitcoin-chainstate
REVERT: 6fd40a85c58 kernel: Add functions to get the block hash from a block
REVERT: 5a455e0f302 kernel: Add block index utility functions to C header
REVERT: 0ecac1bb090 kernel: Add function to read block undo data from disk to C header
REVERT: aa3a766eefc kernel: Add functions to read block from disk to C header
REVERT: b0e4555ed33 kernel: Add function for copying  block data to C header
REVERT: 145bd659066 kernel: Add functions for the block validation state to C header
REVERT: b45b99fbb79 kernel: Add validation interface to C header
REVERT: 881f91aab96 kernel: Add interrupt function to C header
REVERT: fdd3ba615ca kernel: Add import blocks function to C header
REVERT: 1484e67bf08 kernel: Add chainstate load options for in-memory dbs in C header
REVERT: ab872e24041 kernel: Add options for reindexing in C header
REVERT: 1abb7360f88 kernel: Add block validation to C header
REVERT: c42bfed83d4 kernel: Add chainstate loading when instantiating a ChainstateManager
REVERT: 1b7df118081 kernel: Add chainstate manager option for setting worker threads
REVERT: 5f61d9eafde kernel: Add chainstate manager object to C header
REVERT: a677be25c5d kernel: Add notifications context option to C header
REVERT: 1d567b07136 kernel: Add chain params context option to C header
REVERT: 60aed1c857c kernel: Add kernel library context object
REVERT: ad5c98980a0 kernel: Add logging to kernel library C header
REVERT: 6ba27ef2b41 kernel: Introduce initial kernel C header API

git-subtree-dir: libbitcoinkernel-sys/bitcoin
git-subtree-split: 29513955891e40e78466f2c666dfa13e9c1b2914
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants