Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update terminal notification setup #337

Closed
klappradla opened this issue Mar 7, 2022 · 4 comments
Closed

Update terminal notification setup #337

klappradla opened this issue Mar 7, 2022 · 4 comments
Labels

Comments

@klappradla
Copy link
Member

As it turned out in #336, the webpack-build-notifier package we're using in development isn't compatible with Apple's new M1 architecture and probably won't in the near future. See this issue for some background on this.

How should we proceed on this:

  1. Find an alternative more future-proof setup?
  2. Get rid of the terminal notifications altogether?
@pmeinhardt
Copy link
Contributor

I suppose one could try to conditionally disable the plugin on Apple Silicon - possibly using Node.js' os.arch() or process.arch – but at that point I'd be leaning towards removing the dependency. 🙂

@pmeinhardt
Copy link
Contributor

…under the assumption it's a runtime error, not one at install-time. I don't have an M1, so I can't tell. 🙂

@tessi
Copy link
Contributor

tessi commented Apr 27, 2022

👋 to be honest, I have no idea what the error is about or where it's triggered. But I have an M1 mac at hand and could test whatever you want me to test :)

klappradla added a commit that referenced this issue Apr 27, 2022
Remove the `webpack-build-notifier` package. It relies on unmaintained
packages which aren't compatible with M1 Macs out of the box any more.

Closes #337

(ticket: #337)
@klappradla
Copy link
Member Author

Thanks @pmeinhardt & @tessi 💚

I also have an M1 and could test it there. But I prefer to have the setup run quick and friction-less for anyone looking to contribute. The extra complexity and respective maintenance effort just for the sake of the build notification does not feel worth the effort to me. The time would be better spend speeding up the build itself 😉

Therefore going with simply removing the notifier 🧹

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants