Safari Web Extension Port from App Extension #1491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ature/safari-webext # Conflicts: # src/background/runtime.background.ts
kspearrin
previously approved these changes
Dec 11, 2020
…fari-webext # Conflicts: # src/browser/safariApp.ts # src/safari/safari/SafariExtensionViewController.swift # src/services/browserPlatformUtils.service.ts
cscharf
reviewed
Jan 13, 2021
cscharf
approved these changes
Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports the existing Safari App Extension to the new Web Extension. Which eliminates most of the custom code required to support Safari. It also bumps the required safari version to 14.
The old xcode project was removed and a new was generated using the web extension converter.
Three features still depends on custom handlers in the Extension, but it's a fair improvement compared to before.
I also had to add a workaround: