-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SMPlayer #148
SMPlayer #148
Conversation
pending/xnview.xml
Outdated
v0.1 done on 2018-12-19 | ||
|
||
--> | ||
<cleaner id="xnview.new"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conflicts with #145
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, reverted now the old XnViewer pull...
Sorry, but I'm really not so the pro with git... Think my first patch was done from my master and so I had/have a old version of the patch in every branch... :-/ ... I try to revert & fix that... |
</option> | ||
<option id="screenshots"> | ||
<label>Screenshots</label> | ||
<description>Remove screenshots image files from default location</description> | ||
<action command="delete" search="glob" path="~/.config/smplayer/screenshots/*"/> | ||
<action command="delete" search="glob" path="%USERPROFILE%\.smplayer\screenshots\*"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: This is a good use of glob
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:-)
pending/smplayer.xml
Outdated
<option id="playlist_contents"> | ||
<label>Playlists on Windows</label> | ||
<description>Remove saved (internal) playlists on Windows</description> | ||
<action command="ini" search="glob" path="%USERPROFILE%\.smplayer\smplayer.ini" name="item_0_filename"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you please change these globs to search="file"
because there is no wildcard?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
@Tobias-B-Besemer By the way, I noticed that some entries were cleaned only for the Windows path. The latest version of BleachBit in Git has a solution that can help with this, assuming the .ini is the same on Linux but with a different path. It is called multi-value variables, and you can see examples in the google_chrome.xml cleaner (the Git version). |
I guess in this case it doesn't matter if the path is written with "/", or ""? This pull request is closed, but I try to push a new PR here, anyway. |
OK, Git created a new Pull Request... It's #157. |
Clean SMPlayer thanks to Tobias-B-Besemer
No description provided.