Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header content alignment issue, hide navbar on outside click #2238

Merged
merged 4 commits into from
Jun 25, 2019
Merged

Header content alignment issue, hide navbar on outside click #2238

merged 4 commits into from
Jun 25, 2019

Conversation

maxgrapps
Copy link
Contributor

@maxgrapps maxgrapps commented Jun 25, 2019 •
edited
Loading

  1. We added fluid container to header to avoid this:
    Screen Shot 2019-06-25 at 11 22 10

Before:
Screen Shot 2019-06-25 at 12 53 11
After:
tg_image_2360692365

  1. We hide navbar on outside click

vbaranov
vbaranov reviewed Jun 25, 2019
View reviewed changes
apps/block_scout_web/assets/css/components/_navbar.scss Outdated
@@ -22,7 +22,7 @@ $navbar-logo-width: auto !default;
font-size: 14px;
}
.navbar-nav {
flex-grow: 1;
// flex-grow: 1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxgrapps let's remove this commented line, if we don't need it

@maxgrapps maxgrapps changed the title Header content alignment issue Header content alignment issue, hide navbar on outside click Jun 25, 2019
@maxgrapps
Copy link
Contributor Author

@vbaranov complete

@vbaranov vbaranov merged commit 75f2856 into blockscout:master Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbaranov vbaranov vbaranov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxgrapps @vbaranov