Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump alloy deps #1623

Merged
merged 2 commits into from
Jul 16, 2024
Merged

chore: bump alloy deps #1623

merged 2 commits into from
Jul 16, 2024

Conversation

rakita
Copy link
Member

@rakita rakita commented Jul 16, 2024

Backported the RecoveredAuthorization to minimize breaking changes.

Another option considered is to have: Recovered(Vec<Option<RecoveredAuthorization>>), in place of Recovered(Vec),` but this loses information on invalid Authorization that some hooks/handler/inspector maybe want to have.

Copy link
Contributor

Valgrind Results:

==4023== Cachegrind, a cache and branch-prediction profiler
==4023== Copyright (C) 2002-2017, and GNU GPL'd, by Nicholas Nethercote et al.
==4023== Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyright info
==4023== Command: target/release/snailtracer
==4023== 
--4023-- warning: L3 cache found, using its data for the LL simulation.
Running snailtracer example!
elapsed: 1.727849374s
==4023== 
==4023== I   refs:      427,039,684
==4023== I1  misses:          3,147
==4023== LLi misses:          2,836
==4023== I1  miss rate:        0.00%
==4023== LLi miss rate:        0.00%
==4023== 
==4023== D   refs:      204,076,848  (132,268,643 rd   + 71,808,205 wr)
==4023== D1  misses:        340,099  (    200,091 rd   +    140,008 wr)
==4023== LLd misses:        137,814  (      4,493 rd   +    133,321 wr)
==4023== D1  miss rate:         0.2% (        0.2%     +        0.2%  )
==4023== LLd miss rate:         0.1% (        0.0%     +        0.2%  )
==4023== 
==4023== LL refs:           343,246  (    203,238 rd   +    140,008 wr)
==4023== LL misses:         140,650  (      7,329 rd   +    133,321 wr)
==4023== LL miss rate:          0.0% (        0.0%     +        0.2%  )

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rakita rakita merged commit 1982f5e into main Jul 16, 2024
26 checks passed
@rakita rakita deleted the rakita/bump_alloy branch July 16, 2024 19:45
@github-actions github-actions bot mentioned this pull request Jul 16, 2024
j75689 pushed a commit to j75689/revm that referenced this pull request Aug 1, 2024
* chore: bump alloy deps

* add From
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants