Add helper functions that would create JournalInit from JournaledState #1879 #1961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #1961 will degrade performances by 2.13%Comparing Summary
Benchmarks breakdown
|
rakita
reviewed
Jan 3, 2025
rakita
reviewed
Jan 3, 2025
crates/context/src/journal_init.rs
Outdated
| pub type JournalInit = JournaledState<EmptyDB>; | ||
|
|
||
| impl<DB> From<&JournaledState<DB>> for JournalInit { | ||
| fn from(state: &JournaledState<DB>) -> Self { |
There was a problem hiding this comment.
This is an expensive operation that clones a lot of fields. would remove it and just add into_init() and to_init() functions to JournaledState
There was a problem hiding this comment.
thx added that! so to_init() is still cloning similar to the rust from/into convention. I think that is what you wanted?
This was referenced Feb 4, 2025
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1879