Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: EthHandler trait #2001

Merged
merged 19 commits into from
Jan 21, 2025
Merged

feat: EthHandler trait #2001

merged 19 commits into from
Jan 21, 2025

Conversation

rakita
Copy link
Member

@rakita rakita commented Jan 15, 2025

This creates one trait with all the logic, and adds transact_main, transact_main_commit, inspect_main and inspect_main_commit functions that require only Context.

Copy link

codspeed-hq bot commented Jan 16, 2025

CodSpeed Performance Report

Merging #2001 will improve performances by 2.88%

Comparing rakita/eth_handler_trait (2c91bba) with main (25512fd)

Summary

⚡ 1 improvements
✅ 7 untouched benchmarks

Benchmarks breakdown

Benchmark main rakita/eth_handler_trait Change
transfer 31 µs 30.1 µs +2.88%

@rakita rakita marked this pull request as ready for review January 20, 2025 16:16
@rakita rakita merged commit 34bc873 into main Jan 21, 2025
27 checks passed
@rakita rakita deleted the rakita/eth_handler_trait branch January 21, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant