improvement: add return value to revert #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakita
reviewed
Jan 25, 2023
rakita
reviewed
Jan 25, 2023
Wodann
force-pushed
the
improvement/revert
branch
from
50cedab to
59e74dc
Compare
rakita
approved these changes
Jan 26, 2023
Wodann
changed the title
This was referenced Feb 4, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EVM allows you to call the
revertopcode with an error message, which needs to be returned as the return value.Additionally, I added the logs that are collected up to the point
revertwas called. This allows debugging tools built on top ofrevmwithout adding additional cost - as we're just bubbling up the data.