Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(interpreter): halt on CreateInitcodeSizeLimit #412

Merged
merged 1 commit into from
Mar 9, 2023
Merged

fix(interpreter): halt on CreateInitcodeSizeLimit #412

merged 1 commit into from
Mar 9, 2023

Conversation

rkrasiuk
Copy link
Collaborator

@rkrasiuk rkrasiuk commented Mar 9, 2023

From EIP 3860:

If length of initcode to CREATE or CREATE2 instructions exceeds MAX_INITCODE_SIZE, instruction execution exceptionally aborts (as if it runs out of gas).

@rkrasiuk
Copy link
Collaborator Author

rkrasiuk commented Mar 9, 2023

@rakita this fixes the failing state tests

@rakita
Copy link
Member

rakita commented Mar 9, 2023

Yes it does, initcode size check is done before the call is made, so the InstructionResult can be exposed to the first call, missed that.

@rakita rakita merged commit d8dc652 into bluealloy:main Mar 9, 2023
@rkrasiuk rkrasiuk deleted the rkrasiuk/fix-init-code-size-limit branch March 9, 2023 11:23
@rkrasiuk rkrasiuk mentioned this pull request Mar 9, 2023
Merged
This was referenced Feb 4, 2025
Closed
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkrasiuk @rakita