Skip to content
This repository has been archived by the owner on Jan 30, 2025. It is now read-only.

Bump deactivation module version to 1.2.0 #1134

Merged
merged 5 commits into from
Jun 19, 2024

Conversation

wpalani
Copy link
Member

@wpalani wpalani commented Jun 19, 2024

Proposed changes

Bump deactivation module from 1.1.2 to 1.2.0, which includes:

  • Add a deactivation duration drop-down.
  • Fix an issue where events are not sent to analytics.
  • Fix a full-screen scroll bug on mobile.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@wpalani wpalani requested review from circlecube and wpscholar June 19, 2024 16:30
Copy link

cypress bot commented Jun 19, 2024

3 failed tests on run #8761 ↗︎

3 387 59 0 Flakiness 0

Details:

Fix merge conflict
Project: Bluehost Brand Plugin Commit: d4d878aa6f
Status: Failed Duration: 24:17 💡
Started: Jun 19, 2024 5:17 PM Ended: Jun 19, 2024 5:41 PM
Failed  vendor/newfold-labs/wp-module-coming-soon/tests/cypress/integration/coming-soon.cy.js • 1 failed test

View Output Video

Test Artifacts
Coming Soon > Launching launches site Test Replay Screenshots Video
Failed  vendor/newfold-labs/wp-module-deactivation/tests/cypress/integration/deactivation-survey.cy.js • 2 failed tests

View Output Video

Test Artifacts
Plugin Deactivation Survey > Continue button exists and advances to survey, skip button functions Test Replay Screenshots Video
Plugin Deactivation Survey > Survey successfully deactivates plugin Test Replay Screenshots Video

Review all test suite changes for PR #1134 ↗︎

Copy link

cypress bot commented Jun 19, 2024

4 failed and 1 flaky tests on run #8756 ↗︎

4 382 58 2 Flakiness 1

Details:

Merge 8b2273d into 3aa27b2...
Project: Bluehost Brand Plugin Commit: 12fcc9bbee ℹ️
Status: Failed Duration: 27:04 💡
Started: Jun 19, 2024 4:33 PM Ended: Jun 19, 2024 5:00 PM
Failed  vendor/newfold-labs/wp-module-deactivation/tests/cypress/integration/deactivation-survey.cy.js • 2 failed tests

View Output Video

Test Artifacts
Plugin Deactivation Survey > Continue button exists and advances to survey, skip button functions Test Replay Screenshots Video
Plugin Deactivation Survey > Survey successfully deactivates plugin Test Replay Screenshots Video
Failed  vendor/newfold-labs/wp-module-ecommerce/tests/cypress/integration/Site-Capabilities/siteCapabilities.cy.js • 1 failed test

View Output Video

Test Artifacts
Verify Wondercart accessibility as per site capabilities > Verify clicking Install Now successfully installs Wonder Cart plugin Test Replay Screenshots Video
Failed  vendor/newfold-labs/wp-module-ecommerce/tests/cypress/integration/Store/storePage.cy.js • 1 failed test

View Output Video

Test Artifacts
Store Page- WooCommerce is deactivated/uninstalled > Verify that Payments tab is not displayed Test Replay Screenshots Video
Flakiness  vendor/newfold-labs/wp-module-ecommerce/tests/cypress/integration/Home/commerceHomePage.cy.js • 1 flaky test

View Output Video

Test Artifacts
Commerce Home Page- Next Steps > Verify Next steps when experience level is novice Test Replay Screenshots Video

Review all test suite changes for PR #1134 ↗︎

@wpalani wpalani merged commit 82789e8 into develop Jun 19, 2024
1 of 3 checks passed
@wpalani wpalani deleted the add/deactivation-module-bump branch June 19, 2024 18:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants