Skip to content
This repository has been archived by the owner on Jan 30, 2025. It is now read-only.

New: include new burst safety folder #1499

Merged
merged 2 commits into from
Jan 8, 2025
Merged

New: include new burst safety folder #1499

merged 2 commits into from
Jan 8, 2025

Conversation

AleTorrisi
Copy link
Contributor

Proposed changes

This change is required to implement all changes implemented on this PR for the module "Performance".

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • [] Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@arunshenoy99 arunshenoy99 changed the base branch from main to develop January 7, 2025 09:15
@arunshenoy99 arunshenoy99 self-requested a review January 7, 2025 09:15
@cypress Cypress
Copy link

cypress bot commented Jan 7, 2025 •
edited
Loading

Bluehost Brand Plugin    Run #12540

Run Properties:  status check passed Passed #12540  •  git commit 81a4da3091 ℹ️: Merge 18121f04f9a456b644d08d9eb3402f2695844e60 into 7bed5151a1dd7ea79103ab8b0290...
Project Bluehost Brand Plugin
Branch Review press7-93/burstsafetymode
Run status status check passed Passed #12540
Run duration 31m 48s
Commit git commit 81a4da3091 ℹ️: Merge 18121f04f9a456b644d08d9eb3402f2695844e60 into 7bed5151a1dd7ea79103ab8b0290...
Committer Alessio Torrisi
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 33
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 410
View all changes introduced in this branch ↗︎

@arunshenoy99 arunshenoy99 mentioned this pull request Jan 8, 2025
Merged
14 tasks
@arunshenoy99 arunshenoy99 changed the base branch from develop to update/performance January 8, 2025 16:22
arunshenoy99
arunshenoy99 reviewed Jan 8, 2025
View reviewed changes
Copy link
Member

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @AleTorrisi, I am merging this into the bump PR for performance since this change has to go along with that version.

@arunshenoy99 arunshenoy99 merged commit c704203 into update/performance Jan 8, 2025
2 of 3 checks passed
@arunshenoy99 arunshenoy99 deleted the press7-93/burstsafetymode branch January 8, 2025 16:23
@circlecube circlecube added this to the January 15, 2025 Release milestone Jan 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arunshenoy99 arunshenoy99 arunshenoy99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
January 22, 2025 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@AleTorrisi @arunshenoy99 @circlecube