core: services: cable_guy: Move interface priority from ipr to dhcpcd #1902
Conversation
patrickelectric
force-pushed
the
fix-interfaces-order
branch
from
ce1e614 to
3451652
Compare
patrickelectric
force-pushed
the
fix-interfaces-order
branch
5 times, most recently
from
71b423b to
dfb14d8
Compare
patrickelectric
force-pushed
the
fix-interfaces-order
branch
2 times, most recently
from
8992a35 to
869275f
Compare
| @@ -3,7 +3,7 @@ | |||
| <v-list> | |||
| <v-card-subtitle class="text-md-center" max-width="30"> | |||
| Move network interfaces over | |||
| to change network access priority | |||
| to change network access priority.<br>Applied changes require a <b>system reboot</b>. | |||
There was a problem hiding this comment.
can we make it show the reboo-required icon we use for parameter changes? even in bold this is quite subtle.
Or maybe a popup after saving saying "configurations will be applied on the next boot", if that is easier.
There was a problem hiding this comment.
can we make it show the reboo-required icon we use for parameter changes? even in bold this is quite subtle. Or maybe a popup after saving saying "configurations will be applied on the next boot", if that is easier.
Yes, but that idea is under #1962, to be a global notifier.
| return metric | ||
| lines = self._get_service_dhcpcd_content() | ||
| result = [] | ||
| current_interface = None |
There was a problem hiding this comment.
did you miss the type here? it looks like you missed the type, and that caused the errors in line 480 and 482 that you suppressed.
There was a problem hiding this comment.
I did try to apply the type, but is unrelated, the source of the issue is from mypy.
python/mypy#14987
|
btw, I tested with |
Signed-off-by: Patrick José Pereira <[email protected]>
…o_ipr Signed-off-by: Patrick José Pereira <[email protected]>
Signed-off-by: Patrick José Pereira <[email protected]>
… update Signed-off-by: Patrick José Pereira <[email protected]>
… applying Signed-off-by: Patrick José Pereira <[email protected]>
…s if applying new priority Signed-off-by: Patrick José Pereira <[email protected]>
Signed-off-by: Patrick José Pereira <[email protected]>
…system reboot Signed-off-by: Patrick José Pereira <[email protected]>
patrickelectric
force-pushed
the
fix-interfaces-order
branch
from
869275f to
7726840
Compare
|
Here it's not changing the metrics (seeing using |
did you reboot ? |
I did not. Oops |
priority_menu_forever_loading.mp4edit: unable to replicate after the recording. |
Fix #1539
Right now to have it working it's required to do a system reboot.
Doing dhcpcd service restart breaks our wpa_supplicant connection. #1958 was an attempt to fix that.