Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a UK tides block - server side rendered - to replace the [bw_tides] shortcode #19

Closed
bobbingwide opened this issue Dec 13, 2018 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@bobbingwide
Copy link
Owner

Requirements

  • Display UK tides information in a block
  • Implement a block for the [bw_tides] shortcode
  • Attempt to short circuit the need for the oik base plugin

Proposed solution

  • New block oik-block/uk-tides - UK tide times and heights
  • Depends on uk-tides for the server logic
  • Implemented as a dynamic block for server side rendering
  • Support easier to use parameter for source of tidal information
  • Support easier to use parameter for specifiying the location
  • Server side rendering to be performed when the block is not selected.

The block to be added to the list of experimental blocks in #16.

@bobbingwide bobbingwide added the enhancement New feature or request label Dec 13, 2018
@bobbingwide bobbingwide self-assigned this Dec 13, 2018
@bobbingwide
Copy link
Owner Author

Another one for the problem determination. If your new block does not appear in the list check the console. You may see something like..

Block "oik-block/search" is already registered

@bobbingwide
Copy link
Owner Author

Noticed today that the block no longer works for https://tidetimes.org.uk but it does for https://www.tidetimes.org.uk

@bobbingwide
Copy link
Owner Author

bobbingwide commented Jan 4, 2020

I now want to implement this block in the uk-tides plugin as uk-tides\uk-tides. Rather than transfer the issue I've created a new one. bobbingwide/uk-tides#7 The oik-block\uk-tides block will either be deprecated or simply dropped.

@bobbingwide
Copy link
Owner Author

The UK tides block is now longer delivered as part of oik-blocks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant