Fix test target framework issues #1958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also made this NuGet warning associated with this mistake into an error. Relates to bonsai-rx#1948 and bonsai-rx#1952
This also enforces which target frameworks are permitted for test projects to avoid mistakes that would cause tests to be silently skipped on CI.
glopesdev
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
Looks great, I didn't know about problem matchers, will have to dig a bit more into it. Would be nice if there was a way to always surface any restore/build warnings to the UI no matter what they are. Catching particular errors is also a good way to go for now.
As a result, test projects are only allowed to target one of those three target frameworks. This is enforced by the build system in order to avoid the easy mistake of having an entire test suite skipped without knowing.
This is also a good idea, I can definitely imagine this happening when some new .NET comes along, but it's not a bad compromise either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a mistake made in #1952
Bonsai.Editor.Testsnow targetsnet8.0-windowsas appropriatenet8.0-windowstests on LinuxThe last one was somewhat annoying as
dotnet testdoesn't have a great way to just run tests for all target frameworks except one or something similar. In the end I opted to runnet472,net8.0, andnet8.0-windowsall as discrete steps (which will actually be kinda nice anyway.)As a result, test projects are only allowed to target one of those three target frameworks. This is enforced by the build system in order to avoid the easy mistake of having an entire test suite skipped without knowing.
I also looked into why GitHub Actions didn't highlight these warnings in the workflow summary. Turns out it actually did highlight them, so we're just bad and both missed it. The warnings just didn't show up on the PR because they aren't associated with any particular file within the PR.
It might be nice if warnings like that ended up on the PR anyway. Not sure if there's an easy way to do that unfortunately. Easiest solution is probably that we just get in the habit of reviewing the workflow run as part of code reviews.
As an aside though, I did find out more about how this GitHub Actions feature works. They're called problem matchers and are documented here. They can be customized, and it turns out
setup-dotnetand such tend to add their own relevant patterns.Relates to #1948