Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for context-dependent renaming of subjects #921

Merged
merged 7 commits into from
Aug 8, 2022

Conversation

glopesdev
Copy link
Member

@glopesdev glopesdev commented Jun 7, 2022

This PR adds support for context-dependent renaming of subjects across a workflow. The renaming itself happens through the matching subject node in the toolbox, either by right-clicking on the node, or pressing F2 in either the node or the search bar (supporting search and rename).

The operation will correctly identify the source of the subject declaration, and propagate the rename to all dependents and can be initiated either on the original declaration, or in any dependent (subscribe or multicast). Views are refreshed immediately upon rename and undo/redo is supported.

Fixes #702
Fixes #933

@glopesdev glopesdev added the feature New planned feature label Jun 7, 2022
@glopesdev glopesdev added this to the 2.7.0 milestone Jun 7, 2022
@glopesdev
Copy link
Member Author

Renaming should not go inside IncludeWorkflow nodes as they are read-only.

@glopesdev
Copy link
Member Author

This could also be a good opportunity to address #933

@glopesdev
Copy link
Member Author

It would be great to add a "Go to Definition" option also to the context menu for Subjects in the toolbox, so it becomes possible to quickly find the definitions of all listed subjects.

Furthermore, also for each subject listed in the toolbox, it would be great to list as auxiliary information the type of subject in parentheses.

@glopesdev glopesdev merged commit 823349b into bonsai-rx:master Aug 8, 2022
@glopesdev glopesdev deleted the issue-702 branch August 8, 2022 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New planned feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add editor support for finding subject definitions Add support for refactoring subject names
1 participant