Support mashup of both rolling and 2D graph panels #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to extend support for graph mashup by refactoring
GraphPanelto allow composition of 2D line graphs and introducingRollingGraphPanelto support composition of both rolling graphs and bar graphs for displaying trends over time. The design goal for both graph panel types is below:RollingGraphPanel: typically used to represent trends or patterns in the data over timeGraphPanel: typically used to show the relationship between two or more variablesThe two types of composition panels are expected to evolve significantly in the near future, so the current API must be treated as highly experimental and subject to change.