Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "numfmt.d.ts" to package.json as types entry #38

Closed
wants to merge 1 commit into from

Conversation

fw6
Copy link

@fw6 fw6 commented Mar 14, 2023

No description provided.

@rmdort
Copy link

rmdort commented Jun 14, 2023

Can we get this merged ? Very helpful to have a typescript definition.

@borgar
Copy link
Owner

borgar commented Jun 14, 2023

Sorry for the delay, I've been considering my options here as well as little time to spare.

The work here looks really good, but:

  • I do not actively use TypeScript and don't have a good ability to maintain the types in this format. So I am reluctant to accept this because the type definitions would either go stale if I changed things, or would simply deter me from making changes.

  • Secondly, I have been considering an overhaul/flattening of the interface and using JSDoc to generate the documentation (and types!) automatically.

I understand the need for types and would like to add them, but I think it needs to be in a form where I can manage them. So my plan at the moment is to redo the interface and add JSDoc types as I go along, basing them on the work here.

If you are impatient then there is of course nothing stopping you from adding and maintaining types over at DefinitelyTyped while the package does not have them. But I really do intend to address this asap.

@borgar borgar mentioned this pull request May 16, 2024
@borgar borgar closed this in #47 May 16, 2024
@borgar borgar closed this in e5a1966 May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants