Basic BigInt support #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should not crash when passed a bigint. This patch will make it so that the formatter will convert the bigint to a number if possible, else it will emit an overflow string (#####). A setting has been added so that instead of the overflow string, a string version of the bigint is emitted instead. This is similar how date overflows are handled. I have made an attempt at supporting bigint throughout the library with some success, but I have abandoned that because it was complicating the code a lot and I had some worries about performance. I think partial support would be possible with low cost. But I don't have the resources to spare for that right now. Closes #61
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not crash when passed a bigint. This patch will make it so that the formatter will convert the bigint to a number if possible, else it will emit an overflow string (#####). A setting has been added so that instead of the overflow string, a string version of the bigint is emitted instead. This is similar how date overflows are handled.
I have made an attempt at supporting bigint throughout the library with some success, but I have abandoned that because it was complicating the code a lot and I had some worries about performance.
I think partial support would be possible with low cost. But I don't have the resources to spare for that right now.
Closes #61