Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing merge PR for RPCv2 CBOR #3406

Open
wants to merge 3 commits into
base: rpcv2-cbor-protocol-support
Choose a base branch
from

Conversation

SamRemis
Copy link
Contributor

@SamRemis SamRemis commented Feb 25, 2025

Changes included:

  • Bugfix on string serialization,
  • minor PR feedback on the parsers file
  • fixing a broken import
  • adds a changelog
  • no longer relies on the default byte order for int.to_bytes that was introduced in 3.11
  • runs pre-commit on the cbor decoding tests.

Note, this is still into the merge PR branch. I'll open a final PR to develop after this is merged, but at that point everything will have been approved

Bugfix on string serialization, minor PR feedback on the parsers file, adds a changelog, and runs pre-commit on the cbor decoding tests.
@SamRemis SamRemis changed the title Preparing merge PR Preparing merge PR for RPCv2 CBOR Feb 25, 2025
Not sure how this one got in there; my IDE has recently been pulling in imports lately.  Will spend some time tomorrow figuring out how to shut that off.
@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (rpcv2-cbor-protocol-support@6c6bba8). Learn more about missing BASE report.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                      Coverage Diff                       @@
##             rpcv2-cbor-protocol-support    #3406   +/-   ##
==============================================================
  Coverage                               ?   92.90%           
==============================================================
  Files                                  ?       66           
  Lines                                  ?    14862           
  Branches                               ?        0           
==============================================================
  Hits                                   ?    13808           
  Misses                                 ?     1054           
  Partials                               ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants