packages: boilerplate kubernetes-1.32 and ecr-credential-provider-1.32 #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koooosh
reviewed
Dec 5, 2024
| %build | ||
| %set_cross_go_flags | ||
|
|
||
| export GO_VERSION="1.22.2" |
There was a problem hiding this comment.
k8s 1.32 will use Go version 1.23.3 (source), so let's update this
koooosh
reviewed
Dec 5, 2024
| %build | ||
| export FORCE_HOST_GO=1 | ||
|
|
||
| export GO_VERSION="1.22.2" |
There was a problem hiding this comment.
Let's update the version here as well
koooosh
approved these changes
Dec 5, 2024
ginglis13
approved these changes
Dec 5, 2024
This was referenced Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add boilerplate for the kubernetes-1.32 and ecr-credential-provider-1.32 packages required for Bottlerocket k8s-1.32 variants. Package sources point to 1.31 sources and will be updated to 1.32 once available. Created by copying the
-1.31equivalent of packages and updating<package>.specandCargo.tomlto define package names and dependencies as-1.32.Issue number:
Tracked in bottlerocket-os/bottlerocket#4318
Description of changes:
Add boilerplate for the kubernetes-1.32 and ecr-credential-provider-1.32 packages required for Bottlerocket k8s-1.32 variants. Package sources point to 1.31 sources and will be updated to 1.32 once available.
Testing done:
make twoliter build-package -e PACKAGE=kubernetes-1_32 -e BUILDSYS_ARCH=aarch64make twoliter build-package -e PACKAGE=kubernetes-1_32 -e BUILDSYS_ARCH=x86_64PR to add real k8s 1.32 sources will include full conformance testing.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.