Add clickable diffs to recent changes view #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
danilax86
commented
Mar 10, 2024
danilax86
commented
bouncepaw
reviewed
Mar 10, 2024
bouncepaw
requested changes
Mar 10, 2024
| @@ -13,6 +13,24 @@ HyphaeLinksHTML returns a comma-separated list of hyphae that were affected by t | |||
| {% endstripspace %} | |||
| {% endfunc %} | |||
|
|
|||
|
|
|||
| HyphaeDiffsHTML returns a comma-separated list of diffs links of current revision for every affected file as HTML string. | |||
| {% func (rev Revision) HyphaeDiffsHTML() %} | |||
There was a problem hiding this comment.
Seen this in action. Works as expected, thank you!
However, I don't like this duplication of the hash. Maybe show it one time only? Something like that maybe:
There was a problem hiding this comment.
This variant without parenthesis looks cleaner. Done!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.