Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] 10.9 Only: Black bar shows after making Brackets full screen on secondary monitor #5308

Open
core-ai-bot opened this issue Aug 30, 2021 · 13 comments

Comments

@core-ai-bot
Copy link
Member

Issue by dalcala
Thursday Oct 31, 2013 at 22:19 GMT
Originally opened as adobe/brackets#5795


Description:
Filing on behalf of@njx who found this bug. On Mac 10.9, a black bar shows in the title bar area if you make Brackets full screen on the secondary monitor. This is a cosmetic issue, but there seems to be a more serious issue with Dark Shell builds if you maximize Brackets on the secondary monitor and then go into Full Screen mode. On Dark Shell builds, when you exit Full Screen mode, the Full Screen button is no longer there. I'll file a separate bug for that to keep the bug reports from getting too long & complicated.

Repro on Mac 10.9 using this build:
http://webauthoringbuild.corp.adobe.com/builds/brackets/FullScreenToolBarButtonFix10164/mac/
Also repros with pre-Dark Shell builds. Repros with release builds from Sprint 33, Sprint 32, Sprint 31.
UTR on Mac 10.8

Repro steps:

  1. Install Brackets on Mac 10.9.
  2. Connect a second monitor to your Mac.
  3. Launch Brackets and make it non-maximized.
  4. Move Brackets over to the secondary monitor.
  5. Click the Full Screen button in Brackets title bar to go into Full Screen mode.

Actual results:
There is a black bar at the top of the screen where the title bar normally is.

bk-full-screen-black-bar

Expected results:
There is no black bar at the top of the screen where the title bar normally is.

Workaround:
If you do Full Screen on the primary monitor, then the problem doesn't occur.

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Wednesday Nov 06, 2013 at 19:11 GMT


I can make older builds do this so I don't think this is a Dark Shell issue. @dalcala can you try an older build like sprint 33 and run though these steps a few times to see if it repros?

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Monday Nov 11, 2013 at 19:24 GMT


Reviewed -- setting medium priority

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Monday Nov 11, 2013 at 19:24 GMT


Removing "[Dark Shell Mac]" suffix per@JeffryBooher's comment that it repros in the regular shell on master as well.

@core-ai-bot
Copy link
Member Author

Comment by dalcala
Monday Nov 11, 2013 at 19:45 GMT


[11/11/13] Yes, this repros in earlier release builds as well: Sprint 33, Sprint 32, Sprint 31 on Mac 10.9. So yes, it's not a Dark Shell issue. I updated the bug report to reflect this new info.

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Wednesday Nov 13, 2013 at 01:51 GMT


FBNC@dalcala -- This actually is no longer a problem with the new dark shell. I have not seen this since we made the changes although we have the related issue #5973 now which is a little different but somewhat related.

@core-ai-bot
Copy link
Member Author

Comment by dalcala
Wednesday Nov 13, 2013 at 22:23 GMT


I still see the black bar on Mac 10.9 using Dark Shell 10692. I just added a screen shot to adobe/brackets#5973 where you can see the black bar. In 5973, you can get into a state where you have the black bar plus the Brackets top chrome which is empty, so it kind of looks like two rows of black, when it should be all white.

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Thursday Nov 14, 2013 at 18:43 GMT


Installed this morning's build 10714 built with the OSX 10.9 SDK and it looks good.

@core-ai-bot
Copy link
Member Author

Comment by njx
Thursday Nov 14, 2013 at 19:21 GMT


I did a fair amount of entering/exiting full screen with the latest build in various cases on both my laptop screen and external monitor, and haven't seen any anomalies so far.

@core-ai-bot
Copy link
Member Author

Comment by njx
Thursday Nov 14, 2013 at 19:23 GMT


One thing I noticed is that if you look closely while exiting full screen on a large monitor, you can see the old-style title bar fade into the new title bar. I don't think this is a big deal though--it's not really obvious and it doesn't look that bad to me.

@core-ai-bot
Copy link
Member Author

Comment by njx
Thursday Nov 14, 2013 at 19:24 GMT


(The more obvious issue is that you get a blank area across the bottom of the window as it's resizing into full screen mode, since the browser doesn't re-layout until afterwards. Would be interesting to figure out if there's some way we could make that nicer, but I don't think it's a showstopper.)

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Thursday Nov 14, 2013 at 19:31 GMT


Yeah I see that too, although for me it's intermittent. Sometimes the OS will stretch the bitmap to fill the display while it's animating while other times it doesn't.

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Thursday Nov 14, 2013 at 23:34 GMT


FBNC@dalcala.

@core-ai-bot
Copy link
Member Author

Comment by dalcala
Friday Nov 15, 2013 at 17:24 GMT


Confirmed fixed using Brackets Sprint 34 b10729 on Mac 10.9. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant