Skip to content
This repository has been archived by the owner on Mar 8, 2020. It is now read-only.

Safari Mask Icon #127

Closed
colbyfayock opened this issue Aug 21, 2018 · 6 comments
Closed

Safari Mask Icon #127

colbyfayock opened this issue Aug 21, 2018 · 6 comments

Comments

@colbyfayock
Copy link

Hey! Any intent of supporting Safari mask icons? Happy to put together a PR :)

<link rel="mask-icon" href="path/to/favicon.svg" color="#ff00ff">
@brunocodutra
Copy link
Owner

I don't see any reason why not, but the feature needs to be added to favicons in order for webapp-webpack-plugin to support it.

@colbyfayock
Copy link
Author

ah gotcha, okay. ill wander over there. thanks

@brunocodutra
Copy link
Owner

brunocodutra commented Aug 22, 2018 via email

@colbyfayock
Copy link
Author

seems like there's a lot of back and forth already about supporting SVG generally. i was going to try to dig a little first, but is the SVG support that you provide from favicons or are you adding that as an additional layer? sounded like supporting SVG was the only thing holding it back

@brunocodutra
Copy link
Owner

brunocodutra commented Aug 22, 2018 via email

@colbyfayock
Copy link
Author

colbyfayock commented Aug 22, 2018

thats what I was thinking, since you provide the support here, but wonder if it's a different use case. i'll leave a note and see whats up over there

Commented on the previous thread itgalaxy/favicons#126

Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants