Skip to content

Commit

Permalink
Remove sauce access keys from travis config
Browse files Browse the repository at this point in the history
With that tests on sauce will not run on devs' forks, which will
hopefully make them less flaky.

I've added the key to travis config variable and made publicly
availible.

Partially addresses: kubernetes#494
  • Loading branch information
bryk committed Mar 30, 2016
1 parent 9ae1dab commit 4eecac7
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
4 changes: 1 addition & 3 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,7 @@ node_js:

addons:
# Run tests that require a browser on SauceLabs CI provider. Learn more at: https://saucelabs.com
sauce_connect:
username: k8s-dashboard-ci
access_key: "18b7e71b-60e9-4177-9a7f-e769977dbb39"
sauce_connect: true

before_script:
# Prepare environment for the Chrome browser. This is required for PRs from forks where
Expand Down
4 changes: 2 additions & 2 deletions build/conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,8 @@ export default {
/**
* Whether to use sauce labs for running tests that require a browser.
*/
useSauceLabs:
!!process.env.SAUCE_USERNAME && !!process.env.SAUCE_ACCESS_KEY && !!process.env.TRAVIS,
useSauceLabs: !!process.env.SAUCE_USERNAME && !!process.env.SAUCE_ACCESS_KEY &&
!!process.env.TRAVIS && process.env.TRAVIS_PULL_REQUEST === 'false',
},

/**
Expand Down

0 comments on commit 4eecac7

Please sign in to comment.