Update liquid.yml change configs for peerswap compatibility #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove fallbackfee as it breaks compatibility with newer peerswap versions and adds new options acceptdiscountct=1 creatediscountct=1 for new elements 23.2.3 Discounted Fees for Confidential Transactions feature
|
@NicolasDorier could you merge this PR? Its more or less critical. If someone is using peerswap without those configs, and someone initiates a swap and uses CT discount feature, the lbtc tx cannot be claimed and gets stuck in the lbtc blockchain and there's no way to claim your funds without elementsd having CT disccounts enabled. It doesnt hurt any other functionality or may cause troubles for anyone else not using peerswap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove
fallbackfeeand add CT configs to regain peerswap compatibility:ElementsProject/peerswap#347
fallbackfee is not needed anymore in newer elements versions.
and adds new options to make peerswap work with new discountfee of elements
acceptdiscountct=1creatediscountct=1for elements 23.2.3 Discounted Fees for Confidential Transactions feature is available
https://blog.blockstream.com/elements-23-2-3-discounted-fees-for-confidential-transactions/