Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some function names #2180

Merged
merged 1 commit into from
Apr 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions btcutil/address.go
Original file line number Diff line number Diff line change
Expand Up @@ -686,8 +686,8 @@ func NewAddressTaproot(witnessProg []byte,
return newAddressTaproot(net.Bech32HRPSegwit, witnessProg)
}

// newAddressWitnessScriptHash is an internal helper function to create an
// AddressWitnessScriptHash with a known human-readable part, rather than
// newAddressTaproot is an internal helper function to create an
// AddressTaproot with a known human-readable part, rather than
// looking it up through its parameters.
func newAddressTaproot(hrp string,
witnessProg []byte) (*AddressTaproot, error) {
Expand Down
2 changes: 1 addition & 1 deletion btcutil/bech32/bech32_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -668,7 +668,7 @@ func BenchmarkConvertBitsDown(b *testing.B) {
}
}

// BenchmarkConvertBitsDown benchmarks the speed and memory allocation behavior
// BenchmarkConvertBitsUp benchmarks the speed and memory allocation behavior
// of ConvertBits when converting from a lower base into a higher base (e.g. 5
// => 8).
//
Expand Down
4 changes: 2 additions & 2 deletions btcutil/gcs/gcsbench_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ var matchAnyBenchmarks = []struct {
{"q10M-f10K", randElems10000000, filter10000},
}

// BenchmarkGCSFilterMatchAny benchmarks the sort-and-zip MatchAny impl.
// BenchmarkGCSFilterZipMatchAny benchmarks the sort-and-zip MatchAny impl.
func BenchmarkGCSFilterZipMatchAny(b *testing.B) {
for _, test := range matchAnyBenchmarks {
test := test
Expand All @@ -184,7 +184,7 @@ func BenchmarkGCSFilterZipMatchAny(b *testing.B) {
}
}

// BenchmarkGCSFilterMatchAny benchmarks the hash-join MatchAny impl.
// BenchmarkGCSFilterHashMatchAny benchmarks the hash-join MatchAny impl.
func BenchmarkGCSFilterHashMatchAny(b *testing.B) {
for _, test := range matchAnyBenchmarks {
test := test
Expand Down
2 changes: 1 addition & 1 deletion btcutil/hdkeychain/extendedkey.go
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,7 @@ func (k *ExtendedKey) DeriveNonStandard(i uint32) (*ExtendedKey, error) {
k.depth+1, i, isPrivate), nil
}

// ChildNum returns the index at which the child extended key was derived.
// ChildIndex returns the index at which the child extended key was derived.
//
// Extended keys with ChildNum value between 0 and 2^31-1 are normal child
// keys, and those with a value between 2^31 and 2^32-1 are hardened keys.
Expand Down
Loading