Restore test workflows #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
This PR fixes issues in the testing workflow and removes depreciation warnings for PHP 8.4
Changeset
The minimum Symfony version has been moved to 5. Symfony 4 is way past EOL and is no longer officially supported.
In the Maze Runner workflow, the version matrix was updated to test a broader spectrum of PHP versions.
The matrix was expanded to test against PHP 8.4 in the unit test workflow.
The
is nullstep for checking the header no longer exists. In Maze Runner 8 this step was renamed tois not present. Due to the upgrade of Maze Runner, this change was necessary.The OOM tests were changed to no longer look at the response from the Symfony server and only look if the event was reported to BugSnag. This response is irrelevant to testing BugSnag.
In the Symfony 6 test fixture, the
memory_limit_increaseBugSnag variable was set to 10 MB to allow for the sending of the crash. A similar thing was done to the Symfony 5 fixture, where the limit set by the OOM test was increased to 10MB. It's the same approach as the one used inbugsnag-laravelto fix a similar issue.Testing
All tests now pass