Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

As a CNB user, the default layers directory should be /layers and the default app directory should be /workspace #77

Closed
sclevine opened this issue Jan 27, 2019 · 1 comment
Closed

As a CNB user, the default layers directory should be /layers and the default app directory should be /workspace #77

sclevine opened this issue Jan 27, 2019 · 1 comment
Milestone
0.1.0

Comments

@sclevine
Copy link
Member

sclevine commented Jan 27, 2019 •
edited
Loading

Acceptance Criteria
When I build an OCI image using the lifecycle:

  • Via pack build or
  • Via manual orchestration of the lifecycle binaries
    And I manually inspect the image contents
    Then I observe that the layers directory is /layers
    And I observe that the app directory is /workspace

Notes

  • Remove any logic that allows app to be a subdirectory of /layers
  • It's okay if re-built images are unable to reuse layers due to the updated lifecycle binaries in the builder, but it would be preferable if the re-builds did not fail. Let's discuss if this is not possible
ekcasey pushed a commit that referenced this issue Mar 28, 2019
@ekcasey
New lifecycle parameter defaults
439b525 
* default layers dir -> /layers
* default app dir -> /workspace
* make defaulting consistent for all params (env can override hardcoded
default)
* prefix env var keys with CNB_ instead of PACK_

[#77]

Signed-off-by: Danny Joyce <[email protected]>
Signed-off-by: Emily Casey <[email protected]>
ekcasey pushed a commit that referenced this issue Mar 28, 2019
@ekcasey
New lifecycle parameter defaults
68323c5 
* default layers dir -> /layers
* default app dir -> /workspace
* make defaulting consistent for all params (env can override hardcoded
default)
* prefix env var keys with CNB_ instead of PACK_

[#77]

Signed-off-by: Danny Joyce <[email protected]>
Signed-off-by: Emily Casey <[email protected]>
@ekcasey ekcasey mentioned this issue Mar 30, 2019
Closed
ekcasey added a commit to buildpacks/pack that referenced this issue Apr 1, 2019
@ekcasey
Use new defaults
ed3cbda 
* lifecycle creates a second volume for the app

[buildpacks/lifecycle#77]
ekcasey added a commit to buildpacks/pack that referenced this issue Apr 1, 2019
@ekcasey
Use new defaults
61888f1 
* lifecycle creates a second volume for the app

[buildpacks/lifecycle#77]

Signed-off-by: Emily Casey <[email protected]>
@mgibson1121
Copy link
Member

This story passes acceptance.

@sclevine sclevine closed this as completed Apr 3, 2019
@jromero jromero added this to the 0.1.0 milestone Aug 19, 2019
@jromero jromero mentioned this issue Jan 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.0
Development

No branches or pull requests
3 participants
@jromero @sclevine @mgibson1121